Add an AndroidManifest.xml flag to disable ImageReader backed Platform Views #46430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Views An internal customer is seeing flickering on some high FPS phones. While we try and reproduce / gain more knowledge of this problem this PR adds a AndroidManifest.xml flag to disable their usage. The boolean flag is: ``` "io.flutter.embedding.android.DisableImageReaderPlatformViews" ``` Adding the following to your manifest will disable their usage: ``` <meta-data android:name="io.flutter.embedding.android.DisableImageReaderPlatformViews" android:value="true" /> ``` - While we try and reproduce and gain more feedback
johnmccutchan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 30, 2023
…135789) flutter/engine@8939f9c...e719b79 2023-09-30 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed subpass filter coverage with image filters (flutter/engine#46431) 2023-09-30 john@johnmccutchan.com Add an AndroidManifest.xml flag to disable ImageReader backed Platform Views (flutter/engine#46430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#135789) flutter/engine@8939f9c...e719b79 2023-09-30 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed subpass filter coverage with image filters (flutter/engine#46431) 2023-09-30 john@johnmccutchan.com Add an AndroidManifest.xml flag to disable ImageReader backed Platform Views (flutter/engine#46430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…m Views (#46430) An internal customer is seeing flickering on some high FPS phones. While we try and reproduce / gain more knowledge of this problem this PR adds a AndroidManifest.xml flag to disable their usage. The boolean flag is: ``` "io.flutter.embedding.android.DisableImageReaderPlatformViews" ``` Adding the following to your manifest will disable their usage: ``` <meta-data android:name="io.flutter.embedding.android.DisableImageReaderPlatformViews" android:value="true" /> ```
johnmccutchan
added a commit
to johnmccutchan/engine
that referenced
this pull request
Nov 14, 2023
… Platform Views (flutter#46430)" This reverts commit 87c3bf1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An internal customer is seeing flickering on some high FPS phones.
While we try and reproduce / gain more knowledge of this problem this PR adds a AndroidManifest.xml flag to disable their usage.
The boolean flag is:
Adding the following to your manifest will disable their usage: