Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP][Impeller] Fix framebuffer blend UVs. (#46489) #46775

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[CP][Impeller] Fix framebuffer blend UVs. (#46489) #46775

merged 1 commit into from
Oct 17, 2023

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Oct 11, 2023 •
edited
Loading

@bdero @jonahwilliams
[Impeller] Fix framebuffer blend UVs. (flutter#46489)
391cffb 
Fixes b/303120488.

There's no need to use the `GetCoverageUVs` utility in this case.
Correct usage here would require the geometry to match the coverage
rectangle of the snapshot in pass space with no further transformations
to the geometry.
We should just render the snapshot texture as-is with simple 0/1 UVs and
the snapshot's transform.
@jonahwilliams jonahwilliams mentioned this pull request Oct 11, 2023
Closed
@chinmaygarde chinmaygarde changed the title [Impeller] Fix framebuffer blend UVs. (#46489) [CP][Impeller] Fix framebuffer blend UVs. (#46489) Oct 12, 2023
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2023
@auto-submit auto-submit bot merged commit 54d5d0f into flutter:flutter-3.16-candidate.0 Oct 17, 2023
@ryanaltair ryanaltair mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees

@jonahwilliams jonahwilliams

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonahwilliams @chinmaygarde @itsjustkevin @bdero