This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Fix Platform.script for flutter_tester"
#46981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b14d346. With flutter#46911, the Platform.script API will return a URI for the compiled temporary wrapper script generated by "flutter test". This will cause issues for tests that expect Platform.script to reflect the directory where "flutter test" was launched.
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 17, 2023
…136695) flutter/engine@2d55e29...2159fdb 2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 751358929d1f to 205b728a8623 (1 revision) (flutter/engine#46982) 2023-10-17 jason-simmons@users.noreply.github.com Revert "Fix `Platform.script` for flutter_tester" (flutter/engine#46981) 2023-10-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 12f6559bd6ed to f3e1cd38e8b0 (1 revision) (flutter/engine#46977) 2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6E-cSq679DjzBMcqY... to Y9mDBoH4BSC6pWFXV... (flutter/engine#46974) 2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 8919fecf15c1 to 751358929d1f (4 revisions) (flutter/engine#46972) 2023-10-16 jonahwilliams@google.com [Impeller] GPUTracer for Metal. (flutter/engine#46846) 2023-10-16 dnfield@google.com Fix `Platform.script` for flutter_tester (flutter/engine#46911) 2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 85c8dca08cbe to 8919fecf15c1 (1 revision) (flutter/engine#46966) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 6E-cSq679Djz to Y9mDBoH4BSC6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b14d346.
With #46911, the Platform.script API will return a URI for the compiled temporary wrapper script generated by "flutter test". This will cause issues for tests that expect Platform.script to reflect the directory where "flutter test" was launched.