[Impeller] Deprecate the exposed Rect fields #47592
Conversation
flar
force-pushed
the
impeller-deprecate-Rect-fields
branch
2 times, most recently
from
84f7872 to
15dff54
Compare
|
Note that I tried adding |
|
In the end these fields should be made private within a few days so the warning is just to prevent new accesses from entering the code base in the meantime. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…137803) flutter/engine@d9b6245...dd620fc 2023-11-02 flar@google.com [Impeller] Deprecate the exposed Rect fields (flutter/engine#47592) 2023-11-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from e6df03a57636 to 3c45f68cd7c2 (4 revisions) (flutter/engine#47620) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The exposed Rect fields prevent future optimizations which will depend on changing the internal storage format.