Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] add example of testing entity with "real" HAL instead of mocking. #47631

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

jonahwilliams
Copy link
Member

As a response to my comments in #47621

@jonahwilliams
Copy link
Member Author

We could probably abstract some of these things a bit better for cases where we want to introspect into what the HAL is actually doing.

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I have no idea how to make this more visible for the next person but looks pretty straightforward to me. Aaron WDUT?

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #47631 at sha 30bf4f9

@jonahwilliams
Copy link
Member Author

seems like there was some gold noise: these aren't golden tests.

@gaaclarke
Copy link
Member

This is great! I have no idea how to make this more visible for the next person but looks pretty straightforward to me. Aaron WDUT?

I think this looks good for this case and the tests I've written so far for the DirectionalGaussianBlurFilterContents. You can't get to the "everything is tested" we agreed upon with this approach today though. If you look at the implementation of DirectionalGaussianBlurFilterContents::RenderFilter the behavior of that method changes depending on the capabilities of the hardware, specifically SupportsDecalSamplerAddressMode. @jonahwilliams do you have an idea how to address this sort of issue? We'd need something like the hardware profile emulation of swiftshader. Otherwise, mocks are going to be our only option for "everything is tested".

@jonahwilliams
Copy link
Member Author

to the "everything is tested" we agreed upon with this approach today though

We didn't agree that everything needed to be tested as in 100% branch/line coverage, just that everything needs tests.

In this case the difference between decal and non-decal is the selected shader which is extremely trivial. But the good news is that all backends that were test on for CI support the decal feature. So if you wanted to cover all the branches, you could do so by changing the capabilities interface to allow selectively disabling already supported features.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2023
@auto-submit auto-submit bot merged commit d5ccb5b into flutter:main Nov 3, 2023
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 3, 2023
…137857)

flutter/engine@72262a2...d5ccb5b

2023-11-03 jonahwilliams@google.com [Impeller] add example of testing entity with "real" HAL instead of mocking. (flutter/engine#47631)
2023-11-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3c45f68cd7c2 to 529fcd5bdffc (3 revisions) (flutter/engine#47655)
2023-11-03 zanderso@users.noreply.github.com Reverts specialization constant PR and one change that used it (flutter/engine#47650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller will affect goldens
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants