This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Add support for the PlatformChannel "Share.invoke" command #48265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
reidbaker
approved these changes
Nov 29, 2023
| Intent sendToIntent = intentCaptor.getValue(); | ||
| assertEquals(sendToIntent.getAction(), Intent.ACTION_SEND); | ||
| assertEquals(sendToIntent.getType(), "text/plain"); | ||
| assertEquals(sendToIntent.getStringExtra(Intent.EXTRA_TEXT), "Flutter"); |
There was a problem hiding this comment.
Nit: can you extract "Flutter" into a variable named expectedContent?
| @@ -549,6 +554,13 @@ default void setFrameworkHandlesBack(boolean frameworkHandlesBack) {} | |||
| * can be pasted. | |||
| */ | |||
| boolean clipboardHasStrings(); | |||
|
|
|||
| /** | |||
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bleroux
force-pushed
the
android_add_support_for_share_invoke
branch
from
e16c704 to
e169ef0
Compare
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 1, 2023
…139342) flutter/engine@74d2df5...c26e6ce 2023-12-01 matanlurey@users.noreply.github.com Roll a new version of googletest (2021->2023). (flutter/engine#48285) 2023-12-01 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add ImageFilter.compose (flutter/engine#48546) 2023-12-01 dnfield@google.com Avoid reloading the kernel snapshot when spawning an isolate in the same group (flutter/engine#48478) 2023-12-01 43054281+camsim99@users.noreply.github.com [Android] Check for text to paste before trying to retrieve data from URI (flutter/engine#48166) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 88a1bcb9e43e to 0a90c366ff87 (3 revisions) (flutter/engine#48549) 2023-11-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK to 3.3.0-174.2.beta (4 revisions) (flutter/engine#48538) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from db3399a541f3 to 88a1bcb9e43e (1 revision) (flutter/engine#48545) 2023-11-30 737941+loic-sharma@users.noreply.github.com [Windows] Begin decoupling text input plugin from the view (flutter/engine#47833) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2d236de89898 to db3399a541f3 (3 revisions) (flutter/engine#48543) 2023-11-30 flar@google.com [Impeller] Add direct tesselation of circles for DrawCircle and Round end caps (flutter/engine#48103) 2023-11-30 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Revert to `drawImage` rendering on Chrome 110 or earlier (flutter/engine#48515) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 6b4bdebaab88 to 2d236de89898 (1 revision) (flutter/engine#48537) 2023-11-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Started expanding the blur clip region (flutter/engine#48535) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0e479728cc1f to 6b4bdebaab88 (1 revision) (flutter/engine#48536) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0968fe18ff75 to 0e479728cc1f (1 revision) (flutter/engine#48534) 2023-11-30 103135467+sealesj@users.noreply.github.com Use Chromium mirror for archive dependency (flutter/engine#48509) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2f01d500a352 to 0968fe18ff75 (2 revisions) (flutter/engine#48531) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 11a15444a3aa to 2f01d500a352 (1 revision) (flutter/engine#48524) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 84fdd36b1eea to 11a15444a3aa (1 revision) (flutter/engine#48523) 2023-11-30 leroux_bruno@yahoo.fr [Android] Add support for the PlatformChannel "Share.invoke" command (flutter/engine#48265) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5d64b1322879 to 84fdd36b1eea (1 revision) (flutter/engine#48521) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 23721750e433 to 5d64b1322879 (1 revision) (flutter/engine#48520) 2023-11-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8wu5EgBh1yJPNOd5W... to Bb2k375udWIltCEAx... (flutter/engine#48519) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5a635f2211ce to 23721750e433 (1 revision) (flutter/engine#48514) 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 928e8950e8e3 to 5a635f2211ce (1 revision) (flutter/engine#48511) 2023-11-29 mdebbar@google.com [web] No implicit view in multi-view mode (flutter/engine#48505) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 8wu5EgBh1yJP to Bb2k375udWIl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139342) flutter/engine@74d2df5...c26e6ce 2023-12-01 matanlurey@users.noreply.github.com Roll a new version of googletest (2021->2023). (flutter/engine#48285) 2023-12-01 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add ImageFilter.compose (flutter/engine#48546) 2023-12-01 dnfield@google.com Avoid reloading the kernel snapshot when spawning an isolate in the same group (flutter/engine#48478) 2023-12-01 43054281+camsim99@users.noreply.github.com [Android] Check for text to paste before trying to retrieve data from URI (flutter/engine#48166) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 88a1bcb9e43e to 0a90c366ff87 (3 revisions) (flutter/engine#48549) 2023-11-30 skia-flutter-autoroll@skia.org Manual roll Dart SDK to 3.3.0-174.2.beta (4 revisions) (flutter/engine#48538) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from db3399a541f3 to 88a1bcb9e43e (1 revision) (flutter/engine#48545) 2023-11-30 737941+loic-sharma@users.noreply.github.com [Windows] Begin decoupling text input plugin from the view (flutter/engine#47833) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2d236de89898 to db3399a541f3 (3 revisions) (flutter/engine#48543) 2023-11-30 flar@google.com [Impeller] Add direct tesselation of circles for DrawCircle and Round end caps (flutter/engine#48103) 2023-11-30 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Revert to `drawImage` rendering on Chrome 110 or earlier (flutter/engine#48515) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 6b4bdebaab88 to 2d236de89898 (1 revision) (flutter/engine#48537) 2023-11-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Started expanding the blur clip region (flutter/engine#48535) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0e479728cc1f to 6b4bdebaab88 (1 revision) (flutter/engine#48536) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 0968fe18ff75 to 0e479728cc1f (1 revision) (flutter/engine#48534) 2023-11-30 103135467+sealesj@users.noreply.github.com Use Chromium mirror for archive dependency (flutter/engine#48509) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 2f01d500a352 to 0968fe18ff75 (2 revisions) (flutter/engine#48531) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 11a15444a3aa to 2f01d500a352 (1 revision) (flutter/engine#48524) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 84fdd36b1eea to 11a15444a3aa (1 revision) (flutter/engine#48523) 2023-11-30 leroux_bruno@yahoo.fr [Android] Add support for the PlatformChannel "Share.invoke" command (flutter/engine#48265) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5d64b1322879 to 84fdd36b1eea (1 revision) (flutter/engine#48521) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 23721750e433 to 5d64b1322879 (1 revision) (flutter/engine#48520) 2023-11-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8wu5EgBh1yJPNOd5W... to Bb2k375udWIltCEAx... (flutter/engine#48519) 2023-11-30 skia-flutter-autoroll@skia.org Roll Skia from 5a635f2211ce to 23721750e433 (1 revision) (flutter/engine#48514) 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 928e8950e8e3 to 5a635f2211ce (1 revision) (flutter/engine#48511) 2023-11-29 mdebbar@google.com [web] No implicit view in multi-view mode (flutter/engine#48505) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 8wu5EgBh1yJP to Bb2k375udWIl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the PlatformChannel
Share.invokemessage on Android (before this PR it is only supported on iOS).Related Issue
Engine side for flutter/flutter#138728
Tests
Adds 2 tests.