[Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. #48298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-exempt: code refactor with no semantic change |
matanlurey
approved these changes
Nov 21, 2023
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2023
…ect blur optimization will apply. (flutter/engine#48298)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 22, 2023
…138861) flutter/engine@7cf9d90...1ae1d53 2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299) 2023-11-22 jonahwilliams@google.com [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298) 2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297) 2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296) 2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295) 2023-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294) 2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293) 2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#138861) flutter/engine@7cf9d90...1ae1d53 2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299) 2023-11-22 jonahwilliams@google.com [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298) 2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297) 2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296) 2023-11-21 matanlurey@users.noreply.github.com Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295) 2023-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294) 2023-11-21 skia-flutter-autoroll@skia.org Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293) 2023-11-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely minor micro optimization. Dont copy the paint too early.
Before
13/269 = ~5%
After:
3/262 = ~1%