[Impeller] Skip mask blur with 0 sigma. #48457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Nov 28, 2023
impeller/aiks/canvas.cc
Outdated
| @@ -202,6 +203,11 @@ bool Canvas::AttemptDrawBlurredRRect(const Rect& rect, | |||
| paint.mask_blur_descriptor->style != FilterContents::BlurStyle::kNormal) { | |||
| return false; | |||
| } | |||
| // A blur sigma that is close to zero should not result in any shadow. | |||
| if (paint.mask_blur_descriptor->sigma.sigma <= kEhCloseEnough && | |||
There was a problem hiding this comment.
fabsf(paint.mask_blur_descriptor->sigma.sigma) <= kEhCloseEnough ?
bdero
approved these changes
Nov 28, 2023
jonahwilliams
added
the
autosubmit
bdero
requested changes
Nov 28, 2023
| // A blur sigma that is close to zero should not result in any shadow. | ||
| if (std::fabs(paint.mask_blur_descriptor->sigma.sigma) <= kEhCloseEnough) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Could you add an early return to SolidRRectBlurContents too?
Because there's no guard against zero sigma, nothing is protecting us from div by zero in IPGaussian, so NaNs are probably propagating from the shader and getting mapped to a negative number on the float format we use for wide gamut.
There was a problem hiding this comment.
(Sorry for the late red light, I just realized what's probably happening here.)
There was a problem hiding this comment.
Good idea! Yes the nan issue, I remember it now. Thanks @bdero :)
jonahwilliams
removed
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2023
…139168) flutter/engine@fd3a33f...97ede15 2023-11-28 jonahwilliams@google.com [Impeller] Skip mask blur with 0 sigma. (flutter/engine#48457) 2023-11-28 jonahwilliams@google.com [Impeller] match sigma scaling to Skia scaling. (flutter/engine#48434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added a commit
to jonahwilliams/engine
that referenced
this pull request
Nov 28, 2023
<0 sigma render incorrectly with wide gamut, but these shouldn't produce shadows at all as far as I can tell. flutter/flutter#138842
2 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
<0 sigma render incorrectly with wide gamut, but these shouldn't produce shadows at all as far as I can tell. flutter/flutter#138842
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139168) flutter/engine@fd3a33f...97ede15 2023-11-28 jonahwilliams@google.com [Impeller] Skip mask blur with 0 sigma. (flutter/engine#48457) 2023-11-28 jonahwilliams@google.com [Impeller] match sigma scaling to Skia scaling. (flutter/engine#48434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<0 sigma render incorrectly with wide gamut, but these shouldn't produce shadows at all as far as I can tell.
flutter/flutter#138842