-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move third_party/yapf
to flutter/third_party/yapf
.
#48847
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
third_party/yapf
to flutter/third_party/yapf
.
auto label is removed for flutter/engine/48847, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/engine/48847, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/engine/48847, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…139948) flutter/engine@d001419...ea1a306 2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from bd5941d727be to 461256aac224 (1 revision) (flutter/engine#48897) 2023-12-11 matanlurey@users.noreply.github.com Move `third_party/yapf` to `flutter/third_party/yapf`. (flutter/engine#48847) 2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from 17bd70326a49 to bd5941d727be (1 revision) (flutter/engine#48896) 2023-12-11 barpac02@gmail.com SemanticsUpdateBuilder migration: introduce `identifier` (flutter/engine#48882) 2023-12-11 barpac02@gmail.com Add support for exposing accessibility identifier as accessibilityIdentifier on iOS (flutter/engine#48858) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
As part of eliminating the Flutter buildroot (flutter/flutter#67373), we are moving all third-party dependencies from
//third_party
to//flutter/third_party
.