Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci.yaml] Add DEPS to emulator tests runIf #48885

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[ci.yaml] Add DEPS to emulator tests runIf #48885

merged 1 commit into from
Dec 11, 2023

Conversation

CaseyHillers
Copy link
Contributor

flutter/cocoon#3333

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

keyonghan
keyonghan approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot merged commit 6acecdf into main Dec 11, 2023
29 checks passed
@auto-submit auto-submit bot deleted the CaseyHillers-patch-3 branch December 11, 2023 21:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
6acecdfe5 [ci.yaml] Add DEPS to emulator tests runIf (flutter/engine#…
83b4178 
…48885)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 4c309195b79d to 5c1f13e1e535 (2 revisions) (#…
0f7ac29 
…139939)

flutter/engine@4c30919...5c1f13e

2023-12-11 matanlurey@users.noreply.github.com Move `third_party/stb` to `flutter/third_party`. (flutter/engine#48845)
2023-12-11 chillers@google.com [ci.yaml] Add DEPS to emulator tests runIf (flutter/engine#48885)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaseyHillers @keyonghan