[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936

camsim99 · 2023-12-12T18:36:10Z

Re-lands #48811 with corrected config file name.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

Adds comment for context.

flutter-dashboard · 2023-12-12T18:36:14Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

ricardoamador · 2023-12-12T21:29:30Z

ci/builders/linux_android_emulator_api_33.json

+                    "test_dependencies": [
+                        {
+                            "dependency": "android_virtual_device",
+                            "version": "28"


Does this also need to be 33 or is this meant to be 28?

I think it's purposely 28 but we probably don't need this test for the purposes of this task so I will delete it!

Ah no problem! Just making sure.

ricardoamador

LGTM

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

loic-sharma · 2023-12-13T18:02:19Z

@camsim99 It looks like there's something wrong with the .ci.yaml contents, validation is failing with:

FormatException: ERROR: Linux linux_android_emulator_tests_api_33 is missing DEPS in runIf

For example: https://github.com/flutter/engine/pull/48849/checks?check_run_id=19610224504

I will revert this change to make the engine tree open again.

…tests run on AVDs with Android 33 & 34" (#48936)" This reverts commit 06f9002.

camsim99 · 2023-12-13T18:04:45Z

@camsim99 It looks like there's something wrong with the .ci.yaml contents, validation is failing with:
FormatException: ERROR: Linux linux_android_emulator_tests_api_33 is missing DEPS in runIf
For example: https://github.com/flutter/engine/pull/48849/checks?check_run_id=19610224504

I will revert this change to make the engine tree open again.

Ah okay thanks for letting me know!

…_tests run on AVDs with Android 33 & 34"" (#48988) Reverts #48936 Initiated by: loic-sharma This change reverts the following previous change: Original Description: Re-lands #48811 with corrected config file name. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

ricardoamador · 2023-12-13T18:05:42Z

Thanks @loic-sharma !

loic-sharma · 2023-12-13T18:06:56Z

@camsim99 Actually, it looks like there's some wider problem happening. See the Engine sheriff chat, @matanlurey is working on a PR to fix the .ci.yaml file. It looks like the revert went through though 😓

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

…140084) flutter/engine@9039ac7...fc32677 2023-12-13 jason-simmons@users.noreply.github.com Revert Dart SDK back to 3.3.0-219.0.dev (flutter/engine#48990) 2023-12-13 flar@google.com [Impeller] Use direct tessellation geometry for simple clip shapes (flutter/engine#48959) 2023-12-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34"" (flutter/engine#48988) 2023-12-13 31859944+LongCatIsLooong@users.noreply.github.com Add a constructor for `GlyphInfo`. (flutter/engine#48971) 2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Refactor surface manager mocking (flutter/engine#48953) 2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 6e5bd9b1d91d to f3401c6186c1 (2 revisions) (flutter/engine#48981) 2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 1e63c048ded7 to 6e5bd9b1d91d (1 revision) (flutter/engine#48973) 2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 927f20598b11 to 1e63c048ded7 (1 revision) (flutter/engine#48968) 2023-12-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 17143c130ab3 to 114f2e8de3e5 (1 revision) (flutter/engine#48969) 2023-12-13 jason-simmons@users.noreply.github.com Workarounds for clang-tidy warnings in the next roll of Clang (flutter/engine#48963) 2023-12-13 matanlurey@users.noreply.github.com Migrate `impeller/**.h` to header guards. (flutter/engine#48962) 2023-12-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 02f28120470f to 17143c130ab3 (1 revision) (flutter/engine#48961) 2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" (flutter/engine#48936) 2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 49e32eb178a7 to 927f20598b11 (3 revisions) (flutter/engine#48956) 2023-12-13 1961493+harryterkelsen@users.noreply.github.com [web:multiview] Make CanvasKitRenderer listen for view creation/disposal events (flutter/engine#48812) 2023-12-12 matanlurey@users.noreply.github.com Move `third_party/swiftshader`, roll buildroot `DEPS`. (flutter/engine#48946) 2023-12-12 flar@google.com [Impeller] Direct tessellation of simple filled round rects (flutter/engine#48919) 2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 8e8d92ac1536 to 49e32eb178a7 (1 revision) (flutter/engine#48949) 2023-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from a677378ae254 to 02f28120470f (1 revision) (flutter/engine#48945) 2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 43a400456ab4 to 8e8d92ac1536 (1 revision) (flutter/engine#48941) 2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 3678212a85b8 to 43a400456ab4 (2 revisions) (flutter/engine#48939) 2023-12-12 matanlurey@users.noreply.github.com Roll `buildroot` and delete `libxml`. (flutter/engine#48906) 2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 16298087c277 to 3678212a85b8 (2 revisions) (flutter/engine#48934) 2023-12-12 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from 82c4571bb2de to a677378ae254 (flutter/engine#48933) 2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 7685acfb6221 to 16298087c277 (1 revision) (flutter/engine#48931) 2023-12-12 mdebbar@google.com [web] Handle resizes at the view level (flutter/engine#48892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…_tests run on AVDs with Android 33 & 34'" (#49101) Re-lands #48936 that was reverted due to missing `DEPS` dependency (added). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

camsim99 and others added 10 commits December 7, 2023 14:57

Add new target + configuration

ddcdd9e

Mark new task as bringup: true

600a3dd

Run in presubmit for testing

ea09d9e

Update linux_android_emulator_33.json

e9238c1

Remove testing change

e59c2c9

Merge branch '33v34_task' of github.com:camsim99/engine into 33v34_task

369567a

Merge branch 'main' into 33v34_task

dd40907

Update .ci.yaml

c13be0a

Adds comment for context.

Rename

5f0126b

Merge branch '33v34_task' of github.com:camsim99/engine into 33v34_task

6e8f612

camsim99 mentioned this pull request Dec 12, 2023

[Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34 #48811

Merged

8 tasks

camsim99 requested a review from ricardoamador December 12, 2023 18:37

ricardoamador reviewed Dec 12, 2023

View reviewed changes

Delete unused test

d12dc9f

ricardoamador approved these changes Dec 12, 2023

View reviewed changes

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2023

auto-submit bot merged commit 06f9002 into flutter:main Dec 13, 2023

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to 06f900260da7 (14 revisions) flutter/flutter#140020

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

77fac0d

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to a8bf8404fdaa (15 revisions) flutter/flutter#140021

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

62c36b9

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to 29a85a7af2a8 (16 revisions) flutter/flutter#140022

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

93c0fbc

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to fdfc424b4992 (17 revisions) flutter/flutter#140026

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

44601d0

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to de3ea554623b (19 revisions) flutter/flutter#140028

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

bc897b4

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to 119d910665bc (20 revisions) flutter/flutter#140032

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

b410ab2

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to 119d910665bc (20 revisions) flutter/flutter#140050

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

59e3705

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to 119d910665bc (20 revisions) flutter/flutter#140053

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

7739871

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to ae61286e4dec (21 revisions) flutter/flutter#140055

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

ce46f11

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to ae61286e4dec (21 revisions) flutter/flutter#140066

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

cf44516

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

loic-sharma added revert Label used to revert changes in a closed and merged pull request. and removed revert Label used to revert changes in a closed and merged pull request. labels Dec 13, 2023

auto-submit bot pushed a commit that referenced this pull request Dec 13, 2023

Revert "[Android] Re-land "Add target to have linux_android_emulator_…

5a8e694

…tests run on AVDs with Android 33 & 34" (#48936)" This reverts commit 06f9002.

auto-submit bot mentioned this pull request Dec 13, 2023

Reverts "[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34"" #48988

Merged

8 tasks

camsim99 mentioned this pull request Dec 13, 2023

Linux linux_android_emulator_tests failing on missing Android emulator flutter/flutter#137947

Closed

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to d2021410fa23 (22 revisions) flutter/flutter#140073

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

deb44bd

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to 44fdca94a951 (25 revisions) flutter/flutter#140083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

e2c0d7e

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

engine-flutter-autoroll mentioned this pull request Dec 13, 2023

Roll Flutter Engine from 9039ac78cf03 to fc3267724e1b (26 revisions) flutter/flutter#140084

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023

06f900260 [Android] Re-land "Add target to have linux_android_emulato…

dc3fbcc

…r_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)

camsim99 mentioned this pull request Dec 15, 2023

[Android] Re-land "Re-land 'Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34'" #49101

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936

[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936

Uh oh!

camsim99 commented Dec 12, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Dec 12, 2023

Uh oh!

ricardoamador Dec 12, 2023

Uh oh!

camsim99 Dec 12, 2023

Uh oh!

ricardoamador Dec 12, 2023

Uh oh!

ricardoamador left a comment

Uh oh!

loic-sharma commented Dec 13, 2023 •

edited

Loading

Uh oh!

camsim99 commented Dec 13, 2023

Uh oh!

ricardoamador commented Dec 13, 2023

Uh oh!

loic-sharma commented Dec 13, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936

[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" #48936

Uh oh!

Conversation

camsim99 commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Dec 12, 2023

Uh oh!

ricardoamador Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

camsim99 Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

ricardoamador Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

ricardoamador left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camsim99 commented Dec 13, 2023

Uh oh!

ricardoamador commented Dec 13, 2023

Uh oh!

loic-sharma commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camsim99 commented Dec 12, 2023 •

edited

Loading

loic-sharma commented Dec 13, 2023 •

edited

Loading

loic-sharma commented Dec 13, 2023 •

edited

Loading