Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian (stretch/testing) support to install-build-deps.sh #493

Merged
merged 1 commit into from
Aug 7, 2015
Merged

Add Debian (stretch/testing) support to install-build-deps.sh #493

merged 1 commit into from
Aug 7, 2015

Conversation

ianloic
Copy link
Contributor

@ianloic ianloic commented Aug 7, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@abarth
Copy link
Contributor

abarth commented Aug 7, 2015

Thanks for the patch. Looks like we need to make the CLA bot happy and then we can land this patch.

LGTM

@ianloic
Copy link
Contributor Author

ianloic commented Aug 7, 2015

I am a Google employee though out on paternity leave right now. I probably
should have done the OSS patching thing first anyway. Once that's done I
wonder how I get blessed by googlebot...

On Thu, Aug 6, 2015 at 9:53 PM Adam Barth notifications@github.com wrote:

Thanks for the patch. Looks like we need to make the CLA bot happy and
then we can land this patch.

LGTM


Reply to this email directly or view it on GitHub
#493 (comment).

ianloic added a commit that referenced this pull request Aug 7, 2015
Add Debian (stretch/testing) support to install-build-deps.sh
@ianloic ianloic merged commit f05d811 into flutter:master Aug 7, 2015
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Jul 12, 2022
Updates our ToGNString implementation to match the Chromium version at
version 4e21091c52ffc65be4df7839cc2e86575237e968 of the upstream repo
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/build/gn_helpers.py

Also switches to absolute (buildroot relative) paths for invocations of
vs_toolchain.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants