This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Run unittests on CI and fix HostBuffer. #49789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
changed the title
bdero
force-pushed
the
bdero/fluttergpu-unittests
branch
from
6755348 to
82698e0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bdero
force-pushed
the
bdero/fluttergpu-unittests
branch
from
2a003da to
f9957c4
Compare
This reverts commit 8f92b56.
This comment was marked as outdated.
This comment was marked as outdated.
zanderso
approved these changes
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2024
…141638) flutter/engine@f206573...eab7bd3 2024-01-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manually bump Dart to 3.4.0-34.0.dev" (flutter/engine#49802) 2024-01-16 bdero@google.com Use the correct impeller-cmake-example mirror (flutter/engine#49791) 2024-01-16 bdero@google.com [Flutter GPU] Run unittests on CI and fix HostBuffer. (flutter/engine#49789) 2024-01-16 bdero@google.com [Flutter GPU] Fix playground shader paths. (flutter/engine#49790) 2024-01-16 737941+loic-sharma@users.noreply.github.com [Windows] Add README (flutter/engine#49779) 2024-01-16 dnfield@google.com Fix typo (flutter/engine#49725) 2024-01-16 jason-simmons@users.noreply.github.com Truncate thread names on Linux to the maximum allowed length (flutter/engine#49781) 2024-01-16 dnfield@google.com [Impeller] Fix hot reload for shaders on Impeller (flutter/engine#49739) 2024-01-16 jiahaog@users.noreply.github.com Add `flutter` prefix to import (flutter/engine#49793) 2024-01-16 ivan.inozemtsev@gmail.com Support running sound null safe kernels from dart_runner (flutter/engine#49598) 2024-01-16 bdero@google.com Manually bump Dart to 3.4.0-34.0.dev (flutter/engine#49792) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/engine#49788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flutter GPU tests were broken, and it turns out that I had never set them up to run on CI. This fixes the HostBuffer and gets the test suite running on CI.