Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download android deps when checking licenses. #49804

Closed
wants to merge 1 commit into from
Closed

Conversation

zanderso
Copy link
Member

PRs like #49797 are failing.

cc @jonahwilliams

@zanderso zanderso requested a review from keyonghan January 16, 2024 20:46
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@keyonghan
Copy link
Contributor

Do we need to bring the excluded_files back as well? Namely revert: #49775

@zanderso
Copy link
Member Author

This change doesn't make sense since tip-of-tree already has the right content in the golden.

@zanderso zanderso closed this Jan 16, 2024
@zanderso zanderso deleted the zanderso-patch-5 branch January 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants