This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Manual roll Dart SDK from d6c08fa9bb54 to 6ff69d6b7f59 (15 revisions)" #49852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
approved these changes
Jan 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
…7f59 (15 revisions)" (flutter/engine#49852)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
…141744) flutter/engine@73a2de5...98c16b4 2024-01-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d6c08fa9bb54 to 6ff69d6b7f59 (15 revisions)" (flutter/engine#49852) 2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 5abf9717ea92 to 31f275e8fcc7 (8 revisions) (flutter/engine#49850) 2024-01-18 30870216+gaaclarke@users.noreply.github.com Reland: [Impeller] Turned on new blur. (#48472) (flutter/engine#49642) 2024-01-17 737941+loic-sharma@users.noreply.github.com [Windows] Reduce Visual Studio build errors caused by keyboard unit tests (flutter/engine#49814) 2024-01-17 30870216+gaaclarke@users.noreply.github.com [Impeller] disabled misleading vulkan golden image tests (flutter/engine#49836) 2024-01-17 737941+loic-sharma@users.noreply.github.com [Windows] Remove unnecessary statics in keyboard (flutter/engine#49834) 2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 5c9e3474cf13 to 5abf9717ea92 (1 revision) (flutter/engine#49831) 2024-01-17 godofredoc@google.com Move mac cache builder to bringup. (flutter/engine#49843) 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Switch from transient stencil-only to depth+stencil buffer." (flutter/engine#49832) 2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from d8da1ee69767 to 5c9e3474cf13 (2 revisions) (flutter/engine#49827) 2024-01-17 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d6c08fa9bb54 to 6ff69d6b7f59 (15 revisions) (flutter/engine#49825) 2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 02e94b3b4d29 to d8da1ee69767 (1 revision) (flutter/engine#49824) 2024-01-17 bdero@google.com Flutter GPU: Add GpuContext.createHostBuffer (flutter/engine#49822) 2024-01-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Klxww53tA4-TG5pA9... to GuU0e5WxJCi92Scz8... (flutter/engine#49823) 2024-01-17 bdero@google.com [Impeller] Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#47987) 2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 31309ff09537 to 02e94b3b4d29 (43 revisions) (flutter/engine#49819) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Klxww53tA4-T to GuU0e5WxJCi9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #49825
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Manual roll requested by aam@google.com
https://dart.googlesource.com/sdk.git/+log/d6c08fa9bb54..6ff69d6b7f59
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-39.0.dev
2024-01-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-38.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-37.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-36.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-35.0.dev
2024-01-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-34.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-33.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-32.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-31.0.dev
2024-01-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-30.0.dev
2024-01-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-29.0.dev
2024-01-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-28.0.dev
2024-01-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-27.0.dev
2024-01-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-26.0.dev
2024-01-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-25.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md