Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll 3b128c545 dart sdk. #50024

Conversation

godofredoc
Copy link
Contributor

Rolls dart sdk to: 3b128c5454834a1aaef37d9bb12595e7c217ab61

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Rolls dart sdk to: 3b128c5454834a1aaef37d9bb12595e7c217ab61
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2024
@auto-submit auto-submit bot merged commit f40e976 into flutter:flutter-3.16-candidate.0 Jan 25, 2024
20 checks passed
bryanoltman added a commit to shorebirdtech/engine that referenced this pull request Feb 1, 2024
* [flutter_releases] Flutter stable 3.16.8 Engine Cherrypicks (flutter#49795)

# Flutter stable 3.16.8 Engine

## Scheduled Cherrypicks

- Roll dart revision: dart-lang/sdk@bc253dce3

* Roll 3b128c545 dart sdk. (flutter#50024)

Rolls dart sdk to: 3b128c5454834a1aaef37d9bb12595e7c217ab61

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* update shorebird dart rev

---------

Co-authored-by: Xilai Zhang <xilaizhang@google.com>
Co-authored-by: godofredoc <godofredoc@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants