This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Manual roll Dart SDK from 82936dcdaf4f to 5a5d4c262200 (2 revisions) #50264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual roll requested by kevinjchisholm@google.com https://dart.googlesource.com/sdk.git/+log/82936dcdaf4f..5a5d4c262200 2024-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-99.0.dev 2024-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-98.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,kevinjchisholm@google.com,matanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
autosubmit
skia-flutter-autoroll
force-pushed
the
dart-sdk-flutter-engine-db1b0c33-367b-4647-8f58-ef393ec4ace8-1706831450
branch
from
981f089 to
b08b37d
Compare
fluttergithubbot
approved these changes
Feb 1, 2024
itsjustkevin
added
autosubmit
zanderso
reviewed
Feb 2, 2024
ci/licenses_golden/excluded_files
Outdated
| ../../../flutter/impeller/geometry/size_unittests.cc | ||
| ../../../flutter/impeller/geometry/trig_unittests.cc | ||
| ../../../flutter/impeller/golden_tests/README.md | ||
| ../../../flutter/impeller/golden_tests_harvester/.dart_tool |
Member
There was a problem hiding this comment.
These shouldn't have been added back. There might be some stale files in the bot's tree, maybe?
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/50264, due to - The status or check suite Linux linux_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
…142783) flutter/engine@dd4c79a...b35153d 2024-02-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 82936dcdaf4f to 5a5d4c262200 (2 revisions) (flutter/engine#50264) 2024-02-01 dkwingsmt@users.noreply.github.com Remove number of arguments from defining Dart FFI (flutter/engine#50153) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Refactor the linux_android targets to make use of recent changes to android virtual device params (flutter/engine#50099) 2024-02-01 goderbauer@google.com Re-add tests deleted on accident (flutter/engine#50223) 2024-02-01 30870216+gaaclarke@users.noreply.github.com [Impeller] updated todos from opengles golden work (flutter/engine#50218) 2024-02-01 flar@google.com Get bounds from RTree in DLBuilder::Build() (flutter/engine#50253) 2024-02-01 chinmaygarde@google.com [Impeller] Remove unused define. (flutter/engine#50250) 2024-02-01 tugorez@users.noreply.github.com Add the focus state related methods to the platform dispatcher (flutter/engine#49841) 2024-02-01 jason-simmons@users.noreply.github.com Fix the output paths of the Web esbuild GN template (flutter/engine#50188) 2024-02-01 chinmaygarde@google.com [Impeller] Delete unnecessary special casing for Vulkan in framebuffer fetch. (flutter/engine#50251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
deleted the
dart-sdk-flutter-engine-db1b0c33-367b-4647-8f58-ef393ec4ace8-1706831450
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual roll requested by kevinjchisholm@google.com
https://dart.googlesource.com/sdk.git/+log/82936dcdaf4f..5a5d4c262200
2024-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-99.0.dev
2024-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-98.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,kevinjchisholm@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md