Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add helper for headless integration tests #50885

Merged

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Feb 22, 2024

We'll add more headless mode tests as part of flutter/flutter#143765.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2024
@auto-submit auto-submit bot merged commit 41c3372 into flutter:main Feb 23, 2024
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 24, 2024
…144071)

flutter/engine@ca24520...7380422

2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 9d8d3f053775 to 45b38664b4ed (1 revision) (flutter/engine#50926)
2024-02-23 matanlurey@users.noreply.github.com Refactor Android `scenario_app` to remove shell entrypoint, simplify. (flutter/engine#50922)
2024-02-23 737941+loic-sharma@users.noreply.github.com [Windows] Add helper for headless integration tests (flutter/engine#50885)
2024-02-23 zanderso@users.noreply.github.com Shift //third_party/icu to //flutter/third_party (flutter/engine#50924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants