Reapply "Bump everything to Android 21" (#51056) #51070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9381fb.
gmackall
approved these changes
Feb 28, 2024
| @@ -47,6 +47,7 @@ | |||
| <src file="../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterImageView.java" /> | |||
| <src file="../../../flutter/shell/platform/android/io/flutter/embedding/android/KeyData.java" /> | |||
| <src file="../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityLaunchConfigs.java" /> | |||
| <src file="../../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/SurfaceTextureSurfaceProducer.java" /> | |||
There was a problem hiding this comment.
Not a blocker but do you know if there is a better way for us to be linting than manually including each source file? Were these files just forgotten, and therefore not having linting enforced?
There was a problem hiding this comment.
Actually it looks like the inclusion is not "manual", we have a script for it, but still people need to run the script? And if they don't do that when adding new files, we won't enforce linting in ci? Is that correct?
There was a problem hiding this comment.
The script runs on CI - this only got updated because I ran it locally.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
…144405) flutter/engine@7b3ef43...1f24eaa 2024-02-29 dnfield@google.com Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070) 2024-02-29 737941+loic-sharma@users.noreply.github.com [Windows] Add view ID runner APIs (flutter/engine#51020) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Merged
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
This was introduced in #51070 - my grepping for `LOLLIPOP` was too aggressive, and apparently the linter didn't catch this. I think it's just a bug in the linter. Fixes b/327717572, because Google internal tests caught this.
XilaiZhang
pushed a commit
to XilaiZhang/engine
that referenced
this pull request
Mar 5, 2024
This was introduced in flutter#51070 - my grepping for `LOLLIPOP` was too aggressive, and apparently the linter didn't catch this. I think it's just a bug in the linter. Fixes b/327717572, because Google internal tests caught this.
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
original description from Dan's pr: This was introduced in #51070 - my grepping for `LOLLIPOP` was too aggressive, and apparently the linter didn't catch this. I think it's just a bug in the linter. Fixes b/327717572, because Google internal tests caught this.
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
…ON_CODES` (#51171) Updates the linting script to ban the use of `VERSION_CODES`. We currently have a mish-mash of using the integers, using `VERSION_CODES`, and even how we import the version codes. This makes it more confusing when doing things like #51070 - I think it is clearer to see `22` than `LOLLIPOP_MR1`. I'd like to get LGTM (or at least no opinion) from all the requested reviewers here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c9381fb.
Reverted in #51056 because it caused failures in the framework. No changes, but framework test has been updated to use an actual robolectric implementation to avoid those failures.
This should not land until flutter/flutter#144348 has landed in the framework.
@gaaclarke @johnmccutchan fyi