Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] Remove now unnecessary diagnostics directory #51180

Merged
miguelfrde merged 2 commits into from
Mar 5, 2024
Merged

[fuchsia] Remove now unnecessary diagnostics directory #51180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1834a0e
[fuchsia] Remove now unnecessary diagnostics directory.
miguelfrde Feb 21, 2024
948bb84
Merge branch 'main' into fx-bye-diagnostics
miguelfrde Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/dart_runner/dart_component_controller.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ bool DartComponentController::CreateAndBindNamespace() {
dart_outgoing_dir_ptr_to_check_on_open_.NewRequest());

// Collect our standard set of directories.
std::vector<std::string> other_dirs = {"debug", "ctrl", "diagnostics"};
std::vector<std::string> other_dirs = {"debug", "ctrl"};

dart_outgoing_dir_ptr_to_check_on_open_.events().OnOpen =
[this, other_dirs](zx_status_t status, auto unused) {
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/flutter/component_v2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ ComponentV2::ComponentV2(

// Collect our standard set of directories along with directories that are
// included in the cml file to expose.
std::vector<std::string> other_dirs = {"debug", "ctrl", "diagnostics"};
std::vector<std::string> other_dirs = {"debug", "ctrl"};
for (auto dir : metadata.expose_dirs) {
other_dirs.push_back(dir);
}
Expand Down