Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mkustermann
Copy link
Member

  • Update documentation for the annotation
  • Add @keepToString annotation to web's Locale class (similar to non-webs Locale class)

Issue flutter/flutter#52759

* Update documentation for the annotation
* Add `@keepToString` annotation to web's `Locale` class (similar to
  non-webs `Locale` class)

Issue flutter/flutter#52759
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Mar 7, 2024
@mkustermann mkustermann requested review from mraleph and osa1 March 7, 2024 08:51
Copy link
Contributor

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the same pragma is defined multiple times, with duplicated documentation, except one of them has a usage example and the other one is not.

Is there a way to move the pragma to a common dependency and document it once there?

@mkustermann
Copy link
Member Author

It looks like the same pragma is defined multiple times, with duplicated documentation, except one of them has a usage example and the other one is not.

Is there a way to move the pragma to a common dependency and document it once there?

They both have the usage example actually.

The duplication arises from the fact that the dart:ui implementation of the normal flutter engine and web engine are completely separated, they don't seem to share any code atm.

I don't want this PR to start creating a dependency from lib/web_ui/lib on vm version in lib/ui/. It wouldn't be very clean either because the annotations.dart is not a dart library but rather a part of ui, it would be very strange if that part is used as part of two separate libraries. So I decided to keep it like this.

@mkustermann mkustermann merged commit 40a4279 into flutter:main Mar 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 7, 2024
…144765)

flutter/engine@0246484...40a4279

2024-03-07 kustermann@google.com Make @keepToString annotation work for web and non-web (flutter/engine#51251)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants