This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Save and restore OpenGL bindings that are changed by fl_renderer_render #51887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
robert-ancell
approved these changes
Apr 4, 2024
Contributor
robert-ancell
left a comment
robert-ancell
left a comment
There was a problem hiding this comment.
Other than the mix of GObject/C++ style this looks good, thanks!
Member
Author
|
Added a test that uses the GL/EGL mocks in |
fl_renderer_render uses the raster thread GL context that is also used by Skia. Skia expects that its bindings have not been changed elsewhere.
jason-simmons
force-pushed
the
linux_restore_gl_bindings
branch
from
9f0c442 to
5e8ded2
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 11, 2024
…146663) flutter/engine@16b0cfd...2d85d12 2024-04-11 skia-flutter-autoroll@skia.org Roll Skia from 08940c2e0c44 to 5101cbe5a6bb (1 revision) (flutter/engine#52066) 2024-04-11 dkwingsmt@users.noreply.github.com Move `Shell::Add/RemoveView` to `PlatformView` and refine embedder API doc (flutter/engine#52003) 2024-04-11 chaopeng@chaopeng.me [Fuchsia] Support per app present latency tracing (flutter/engine#51503) 2024-04-11 jason-simmons@users.noreply.github.com Save and restore OpenGL bindings that are changed by fl_renderer_render (flutter/engine#51887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146663) flutter/engine@16b0cfd...2d85d12 2024-04-11 skia-flutter-autoroll@skia.org Roll Skia from 08940c2e0c44 to 5101cbe5a6bb (1 revision) (flutter/engine#52066) 2024-04-11 dkwingsmt@users.noreply.github.com Move `Shell::Add/RemoveView` to `PlatformView` and refine embedder API doc (flutter/engine#52003) 2024-04-11 chaopeng@chaopeng.me [Fuchsia] Support per app present latency tracing (flutter/engine#51503) 2024-04-11 jason-simmons@users.noreply.github.com Save and restore OpenGL bindings that are changed by fl_renderer_render (flutter/engine#51887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fl_renderer_render uses the raster thread GL context that is also used by Skia. Skia expects that its bindings have not been changed elsewhere.