Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons requested a review from zanderso April 9, 2024 21:14
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@zanderso
Copy link
Member

zanderso commented Apr 9, 2024

Next step is to run these under ASAN.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2024
@auto-submit auto-submit bot merged commit 78b8fbc into flutter:main Apr 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 10, 2024
…146607)

flutter/engine@91ba235...6f8ee9f

2024-04-10 zanderso@users.noreply.github.com Manual roll ICU from a622de35ac31 to bad7ddbf9213 (7 revisions) (flutter/engine#52031)
2024-04-10 jason-simmons@users.noreply.github.com Enable gtest-parallel for Impeller unit tests (flutter/engine#52004)
2024-04-10 whesse@google.com Add additional dependencies to const_finder's pubspec.yaml (flutter/engine#52033)
2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 91e0c0f4bf41 to 5bbca5a30653 (3 revisions) (flutter/engine#52032)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146607)

flutter/engine@91ba235...6f8ee9f

2024-04-10 zanderso@users.noreply.github.com Manual roll ICU from a622de35ac31 to bad7ddbf9213 (7 revisions) (flutter/engine#52031)
2024-04-10 jason-simmons@users.noreply.github.com Enable gtest-parallel for Impeller unit tests (flutter/engine#52004)
2024-04-10 whesse@google.com Add additional dependencies to const_finder's pubspec.yaml (flutter/engine#52033)
2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 91e0c0f4bf41 to 5bbca5a30653 (3 revisions) (flutter/engine#52032)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impeller compiler unit tests are not hermetic, can't be run by gtest-parallel.

2 participants