Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/web_ui/lib/src/engine/dom.dart
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,14 @@ extension DomElementExtension on DomElement {
external JSNumber get _clientWidth;
double get clientWidth => _clientWidth.toDartDouble;

@JS('offsetHeight')
external JSNumber get _offsetHeight;
double get offsetHeight => _offsetHeight.toDartDouble;

@JS('offsetWidth')
external JSNumber get _offsetWidth;
double get offsetWidth => _offsetWidth.toDartDouble;

@JS('id')
external JSString get _id;
String get id => _id.toDart;
Expand Down
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/semantics/checkable.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class Checkable extends PrimaryRoleManager {
super.withBasics(
PrimaryRole.checkable,
semanticsObject,
labelRepresentation: LeafLabelRepresentation.ariaLabel,
preferredLabelRepresentation: LabelRepresentation.ariaLabel,
) {
addTappable();
}
Expand Down
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/semantics/incrementable.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Incrementable extends PrimaryRoleManager {
// the one being focused on, but the internal `<input>` element.
addLiveRegion();
addRouteName();
addLabelAndValue(labelRepresentation: LeafLabelRepresentation.ariaLabel);
addLabelAndValue(preferredRepresentation: LabelRepresentation.ariaLabel);

append(_element);
_element.type = 'range';
Expand Down
Loading