This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Widen CPU affinity set. #53136
Merged
Widen CPU affinity set. #53136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jun 3, 2024
|
What sorts of device(s) did you see this problem on? |
|
I don't have a specific model, just feedback from the Android team. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2024
…149627) flutter/engine@60a7bb2...a6aa5d8 2024-06-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 53c41325c29f to 49b5590c8d80 (4 revisions) (flutter/engine#53181) 2024-06-03 jonahwilliams@google.com Widen CPU affinity set. (flutter/engine#53136) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added a commit
that referenced
this pull request
Jun 7, 2024
This reverts commit 926b292.
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Reverts #53136 b/345642546 shows some massive performance regressions on this patch. i'll rework it so the conditions are only loosened on phones with one fast core.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For devices with 1 fast core, the current affinity set is less idea because it forces UI and raster on the same thread. Widen this to exclude slow cores instead of including only the fast core.