This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove pre-existing diagnostics with no behavioral changes. #54264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
added
the
autosubmit
kevmoo
reviewed
Jul 31, 2024
| } | ||
|
|
||
| Picture CreateSimplePicture() { | ||
| Picture createSimplePicture() { |
Contributor
There was a problem hiding this comment.
might could be private, too!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
…152658) flutter/engine@32f7888...0fbff21 2024-07-31 matanlurey@users.noreply.github.com Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 2024-07-31 matanlurey@users.noreply.github.com Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 2024-07-31 jason-simmons@users.noreply.github.com [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152658) flutter/engine@32f7888...0fbff21 2024-07-31 matanlurey@users.noreply.github.com Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 2024-07-31 matanlurey@users.noreply.github.com Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 2024-07-31 jason-simmons@users.noreply.github.com [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152658) flutter/engine@32f7888...0fbff21 2024-07-31 matanlurey@users.noreply.github.com Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 2024-07-31 matanlurey@users.noreply.github.com Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 2024-07-31 jason-simmons@users.noreply.github.com [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 skia-flutter-autoroll@skia.org Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards flutter/flutter#152636.
Most of these were via
dart --fix.