This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[engine] reland weaken affinity of raster/ui to non-e core instead of only fast core #54616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Once we do Ui = platform, we'll similarly stop setting an affinity for the UI thread at all, which wil fix the reported issue with isolates inheriting affinities. |
matanlurey
approved these changes
Aug 21, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
…instead of only fast core (flutter/engine#54616)
Member
|
late lgtm :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
…instead of only fast core (flutter/engine#54616)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
…instead of only fast core (flutter/engine#54616)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
…instead of only fast core (flutter/engine#54616)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
…instead of only fast core (flutter/engine#54616)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
…instead of only fast core (flutter/engine#54616)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2024
…153884) flutter/engine@b94e009...f493c21 2024-08-21 chinmaygarde@google.com [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 jonahwilliams@google.com [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 matanlurey@users.noreply.github.com Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 chinmaygarde@google.com [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 chris@bracken.jp docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 flar@google.com Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 chris@bracken.jp iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 yjbanov@google.com [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 jonahwilliams@google.com [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Aug 22, 2024
…visions) (#153884)" (#153899) Reverts: #153884 Initiated by: jason-simmons Reason for reverting: flutter/engine@f8d553a introduced a log message that is not expected by the `run_debug_test_android` devicelab test Reverting until an engine build is available with the log removed (see flutter/engine#54699) Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@b94e009...f493c21 2024-08-21 chinmaygarde@google.com [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 jonahwilliams@google.com [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 matanlurey@users.noreply.github.com Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 chinmaygarde@google.com [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 chris@bracken.jp docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 flar@google.com Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 chris@bracken.jp iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 yjbanov@google.com [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 jonahwilliams@google.com [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2024
…instead of only fast core (flutter/engine#54616)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 22, 2024
…153902) flutter/engine@b94e009...85d4be0 2024-08-22 joel.winarske@gmail.com Export GPU symbols for embedder (flutter/engine#54662) 2024-08-22 jason-simmons@users.noreply.github.com [Impeller] Remove a log message in the Vulkan back end that is visible during engine startup (flutter/engine#54699) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 3cd00377cefc to 34aa8ce13af6 (3 revisions) (flutter/engine#54698) 2024-08-21 chris@bracken.jp macOS: Make framework creation consistent with iOS (flutter/engine#54685) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 69f4bd859025 to 3cd00377cefc (8 revisions) (flutter/engine#54693) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 060e40916514 to 025bf8d376d3 (1 revision) (flutter/engine#54692) 2024-08-21 zanderso@users.noreply.github.com Split tests out of Linux Android artifact creation builds (flutter/engine#54683) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 249d3f07c4d5 to 69f4bd859025 (5 revisions) (flutter/engine#54691) 2024-08-21 chinmaygarde@google.com [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 jonahwilliams@google.com [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 matanlurey@users.noreply.github.com Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 chinmaygarde@google.com [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 chris@bracken.jp docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 flar@google.com Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 chris@bracken.jp iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 yjbanov@google.com [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 jonahwilliams@google.com [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
pushed a commit
to jonahwilliams/engine
that referenced
this pull request
Aug 28, 2024
… only fast core (flutter#54616) Some android devices have only a single fast core. We set the threading affinity for UI/Raster to the fast core, which can lead to the UI/Raster being serialized on this thread. Instead, we should weaken /invert the affinity to "Not slow cores". FIxes flutter/flutter#153690 Customer money will see some benchmark regressions but they can deal.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153884) flutter/engine@b94e009...f493c21 2024-08-21 chinmaygarde@google.com [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 jonahwilliams@google.com [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 matanlurey@users.noreply.github.com Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 chinmaygarde@google.com [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 chris@bracken.jp docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 flar@google.com Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 chris@bracken.jp iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 yjbanov@google.com [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 jonahwilliams@google.com [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…visions) (flutter#153884)" (flutter#153899) Reverts: flutter#153884 Initiated by: jason-simmons Reason for reverting: flutter/engine@f8d553a introduced a log message that is not expected by the `run_debug_test_android` devicelab test Reverting until an engine build is available with the log removed (see flutter/engine#54699) Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@b94e009...f493c21 2024-08-21 chinmaygarde@google.com [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 jonahwilliams@google.com [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 matanlurey@users.noreply.github.com Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 chinmaygarde@google.com [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 chris@bracken.jp docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 flar@google.com Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 chris@bracken.jp iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 yjbanov@google.com [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 jonahwilliams@google.com [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153902) flutter/engine@b94e009...85d4be0 2024-08-22 joel.winarske@gmail.com Export GPU symbols for embedder (flutter/engine#54662) 2024-08-22 jason-simmons@users.noreply.github.com [Impeller] Remove a log message in the Vulkan back end that is visible during engine startup (flutter/engine#54699) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 3cd00377cefc to 34aa8ce13af6 (3 revisions) (flutter/engine#54698) 2024-08-21 chris@bracken.jp macOS: Make framework creation consistent with iOS (flutter/engine#54685) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 69f4bd859025 to 3cd00377cefc (8 revisions) (flutter/engine#54693) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 060e40916514 to 025bf8d376d3 (1 revision) (flutter/engine#54692) 2024-08-21 zanderso@users.noreply.github.com Split tests out of Linux Android artifact creation builds (flutter/engine#54683) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 249d3f07c4d5 to 69f4bd859025 (5 revisions) (flutter/engine#54691) 2024-08-21 chinmaygarde@google.com [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 jonahwilliams@google.com [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 matanlurey@users.noreply.github.com Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 chinmaygarde@google.com [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 chris@bracken.jp docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 flar@google.com Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 chris@bracken.jp iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 yjbanov@google.com [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 jonahwilliams@google.com [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…d of only fast core (#54842) â�¦ only fast core (#54616) Some android devices have only a single fast core. We set the threading affinity for UI/Raster to the fast core, which can lead to the UI/Raster being serialized on this thread. Instead, we should weaken /invert the affinity to "Not slow cores". FIxes flutter/flutter#153690 Customer money will see some benchmark regressions but they can deal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some android devices have only a single fast core. We set the threading affinity for UI/Raster to the fast core, which can lead to the UI/Raster being serialized on this thread. Instead, we should weaken /invert the affinity to "Not slow cores".
FIxes flutter/flutter#153690
Customer money will see some benchmark regressions but they can deal.