Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

Closes flutter/flutter#152636.

As of this PR, we no longer cherry-pick specific directories to run dart analyze on.

A few trailing errors across the repo had to be fixed in this PR.

@github-actions github-actions bot added platform-web Code specifically for the web engine e: impeller labels Aug 26, 2024
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 26, 2024

auto label is removed for flutter/engine/54779, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit 72a64e4 into flutter:main Aug 26, 2024
@matanlurey matanlurey deleted the resolve-dart-analysis branch August 26, 2024 22:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 27, 2024
…ions) (#154153)

Manual roll requested by zra@google.com

flutter/engine@f645ca5...b41ca79

2024-08-26 jonahwilliams@google.com [Impeller] fix incorrect origins for mesh gradient computation. (flutter/engine#54762)
2024-08-26 matanlurey@users.noreply.github.com Change the `ci/analyze.sh` script to analyze _all_ of the engine (flutter/engine#54779)
2024-08-26 anforowicz@users.noreply.github.com Use GNI group instead of hardcoding PNG codecs source files. (flutter/engine#54781)
2024-08-26 41930132+hellohuanlin@users.noreply.github.com [ios] Fix text input edit rotor accessibility (flutter/engine#54351)
2024-08-26 zanderso@users.noreply.github.com Ensure orchestrators aren't assigned to 32 core machines (flutter/engine#54754)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…ions) (flutter#154153)

Manual roll requested by zra@google.com

flutter/engine@f645ca5...b41ca79

2024-08-26 jonahwilliams@google.com [Impeller] fix incorrect origins for mesh gradient computation. (flutter/engine#54762)
2024-08-26 matanlurey@users.noreply.github.com Change the `ci/analyze.sh` script to analyze _all_ of the engine (flutter/engine#54779)
2024-08-26 anforowicz@users.noreply.github.com Use GNI group instead of hardcoding PNG codecs source files. (flutter/engine#54781)
2024-08-26 41930132+hellohuanlin@users.noreply.github.com [ios] Fix text input edit rotor accessibility (flutter/engine#54351)
2024-08-26 zanderso@users.noreply.github.com Ensure orchestrators aren't assigned to 32 core machines (flutter/engine#54754)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable dart analyze for all of flutter/engine

4 participants