[Impeller] ensure that srcOver to src conversion takes stroke coverage into account. #54817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 28, 2024
impeller/aiks/aiks_unittests.cc
Outdated
| ASSERT_TRUE(entity.size() >= 1); | ||
| ASSERT_TRUE(contents->IsOpaque()); | ||
| ASSERT_TRUE(contents->IsOpaque(matrix)); |
There was a problem hiding this comment.
Super minor nit: Just IsOpaque({})?
jonahwilliams
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
…ke coverage into account. (flutter/engine#54817)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
…ke coverage into account. (flutter/engine#54817)
zanderso
added a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2024
…154316) Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions) flutter/engine@8d248ae...f48ecf5 2024-08-29 jonahwilliams@google.com [Impeller] Use multiple command buffers for blur submission. (flutter/engine#54846) 2024-08-29 skia-flutter-autoroll@skia.org Roll Skia from 0d8d9d2974fa to e37b6b198016 (1 revision) (flutter/engine#54854) 2024-08-29 matanlurey@users.noreply.github.com Remove `--disable-dart-dev` across `flutter/engine`. (flutter/engine#54845) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from vIJGWtHj4Rdku9Ayv... to NWpblL_DFACOx_Spi... (flutter/engine#54852) 2024-08-28 jonahwilliams@google.com [Impeller] fix clip culling with exp canvas. (flutter/engine#54701) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) (flutter/engine#54851) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from d55406ca32e9 to 0d8d9d2974fa (4 revisions) (flutter/engine#54850) 2024-08-28 jacksongardner@google.com [skwasm] Always do backdrop filter operation even if empty. (flutter/engine#54844) 2024-08-28 matanlurey@users.noreply.github.com Migrate`header_guard_check` to `package:test`. (flutter/engine#54811) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54848) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from cd3d3daafe55 to d55406ca32e9 (10 revisions) (flutter/engine#54847) 2024-08-28 jonahwilliams@google.com [Impeller] ensure that srcOver to src conversion takes stroke coverage into account. (flutter/engine#54817) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from ALNKvSVWQSpw1uxPy... to OKGFjciA5Vd0TQks4... (flutter/engine#54840) 2024-08-28 matanlurey@users.noreply.github.com Remove scorecards and other bading we are no longer tracking/links are borked (flutter/engine#54839) 2024-08-28 omersa@google.com Compile dart2wasm modules using the JS runtime exported compileStreaming (flutter/engine#51488) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 183b9e21b706 to bc3dad16b2d3 (1 revision) (flutter/engine#54838) 2024-08-28 matanlurey@users.noreply.github.com Ignore generated fixture `.dill.deps` files. (flutter/engine#54836) 2024-08-28 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] use the api-level from gn-sdk (flutter/engine#54740) 2024-08-28 jonahwilliams@google.com [Impeller] port clip stack fixes to new canvas. (flutter/engine#54727) 2024-08-28 jonahwilliams@google.com [Impeller] fall back to path rendering on thick paths. (flutter/engine#54822) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BCqzoTS_Sz6-AaSii... to ZL8AvfXX5LFIH1LYN... (flutter/engine#54834) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from ca108745b1de to cd3d3daafe55 (1 revision) (flutter/engine#54832) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 42ddf2278114 to 183b9e21b706 (1 revision) (flutter/engine#54830) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from b519f85c3076 to 42ddf2278114 (1 revision) (flutter/engine#54829) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54827) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 41cb13f65fe6 to ca108745b1de (1 revision) (flutter/engine#54828) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 259010335a55 to 41cb13f65fe6 (2 revisions) (flutter/engine#54826) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 505fb55cd044 to 259010335a55 (1 revision) (flutter/engine#54823) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 8334290a421b to b519f85c3076 (1 revision) (flutter/engine#54821) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 84e4a69da303 to 505fb55cd044 (1 revision) (flutter/engine#54819) 2024-08-27 jonahwilliams@google.com [Impeller] Increase host buffer arena count to 4. (flutter/engine#54808) 2024-08-27 flar@google.com Synchronize accounting for render op depths (flutter/engine#54794) 2024-08-27 34871572+gmackall@users.noreply.github.com Fix broken links in `docs/` (flutter/engine#54815) 2024-08-27 chinmaygarde@google.com [Impeller] Don't override user specification on Vulkan validation in unopt. (flutter/engine#54816) 2024-08-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from b81b344a194f to 8334290a421b (12 revisions) (flutter/engine#54813) 2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 77017d30a455 to 84e4a69da303 (3 revisions) (flutter/engine#54812) 2024-08-27 chinmaygarde@google.com [Impeller] Clarify where to put the metadata in the manifest. (flutter/engine#54814) 2024-08-27 chinmaygarde@google.com [Impeller] Use infinite swapchain present timeouts to avoid logspam. (flutter/engine#54810) 2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 2e1eea538014 to 77017d30a455 (2 revisions) (flutter/engine#54809) 2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from a2e2eb292492 to 2e1eea538014 (4 revisions) (flutter/engine#54806) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from BCqzoTS_Sz6- to ZL8AvfXX5LFI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ... --------- Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#154316) Roll Flutter Engine from 8d248aead383 to f48ecf5b49f6 (40 revisions) flutter/engine@8d248ae...f48ecf5 2024-08-29 jonahwilliams@google.com [Impeller] Use multiple command buffers for blur submission. (flutter/engine#54846) 2024-08-29 skia-flutter-autoroll@skia.org Roll Skia from 0d8d9d2974fa to e37b6b198016 (1 revision) (flutter/engine#54854) 2024-08-29 matanlurey@users.noreply.github.com Remove `--disable-dart-dev` across `flutter/engine`. (flutter/engine#54845) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from vIJGWtHj4Rdku9Ayv... to NWpblL_DFACOx_Spi... (flutter/engine#54852) 2024-08-28 jonahwilliams@google.com [Impeller] fix clip culling with exp canvas. (flutter/engine#54701) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from bc3dad16b2d3 to fed5ce7ea2ad (2 revisions) (flutter/engine#54851) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from d55406ca32e9 to 0d8d9d2974fa (4 revisions) (flutter/engine#54850) 2024-08-28 jacksongardner@google.com [skwasm] Always do backdrop filter operation even if empty. (flutter/engine#54844) 2024-08-28 matanlurey@users.noreply.github.com Migrate`header_guard_check` to `package:test`. (flutter/engine#54811) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54848) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from cd3d3daafe55 to d55406ca32e9 (10 revisions) (flutter/engine#54847) 2024-08-28 jonahwilliams@google.com [Impeller] ensure that srcOver to src conversion takes stroke coverage into account. (flutter/engine#54817) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from ALNKvSVWQSpw1uxPy... to OKGFjciA5Vd0TQks4... (flutter/engine#54840) 2024-08-28 matanlurey@users.noreply.github.com Remove scorecards and other bading we are no longer tracking/links are borked (flutter/engine#54839) 2024-08-28 omersa@google.com Compile dart2wasm modules using the JS runtime exported compileStreaming (flutter/engine#51488) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 183b9e21b706 to bc3dad16b2d3 (1 revision) (flutter/engine#54838) 2024-08-28 matanlurey@users.noreply.github.com Ignore generated fixture `.dill.deps` files. (flutter/engine#54836) 2024-08-28 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] use the api-level from gn-sdk (flutter/engine#54740) 2024-08-28 jonahwilliams@google.com [Impeller] port clip stack fixes to new canvas. (flutter/engine#54727) 2024-08-28 jonahwilliams@google.com [Impeller] fall back to path rendering on thick paths. (flutter/engine#54822) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BCqzoTS_Sz6-AaSii... to ZL8AvfXX5LFIH1LYN... (flutter/engine#54834) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from ca108745b1de to cd3d3daafe55 (1 revision) (flutter/engine#54832) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 42ddf2278114 to 183b9e21b706 (1 revision) (flutter/engine#54830) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from b519f85c3076 to 42ddf2278114 (1 revision) (flutter/engine#54829) 2024-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from OKGFjciA5Vd0TQks4... to ALNKvSVWQSpw1uxPy... (flutter/engine#54827) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 41cb13f65fe6 to ca108745b1de (1 revision) (flutter/engine#54828) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 259010335a55 to 41cb13f65fe6 (2 revisions) (flutter/engine#54826) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 505fb55cd044 to 259010335a55 (1 revision) (flutter/engine#54823) 2024-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 8334290a421b to b519f85c3076 (1 revision) (flutter/engine#54821) 2024-08-28 skia-flutter-autoroll@skia.org Roll Skia from 84e4a69da303 to 505fb55cd044 (1 revision) (flutter/engine#54819) 2024-08-27 jonahwilliams@google.com [Impeller] Increase host buffer arena count to 4. (flutter/engine#54808) 2024-08-27 flar@google.com Synchronize accounting for render op depths (flutter/engine#54794) 2024-08-27 34871572+gmackall@users.noreply.github.com Fix broken links in `docs/` (flutter/engine#54815) 2024-08-27 chinmaygarde@google.com [Impeller] Don't override user specification on Vulkan validation in unopt. (flutter/engine#54816) 2024-08-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from b81b344a194f to 8334290a421b (12 revisions) (flutter/engine#54813) 2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 77017d30a455 to 84e4a69da303 (3 revisions) (flutter/engine#54812) 2024-08-27 chinmaygarde@google.com [Impeller] Clarify where to put the metadata in the manifest. (flutter/engine#54814) 2024-08-27 chinmaygarde@google.com [Impeller] Use infinite swapchain present timeouts to avoid logspam. (flutter/engine#54810) 2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 2e1eea538014 to 77017d30a455 (2 revisions) (flutter/engine#54809) 2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from a2e2eb292492 to 2e1eea538014 (4 revisions) (flutter/engine#54806) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from BCqzoTS_Sz6- to ZL8AvfXX5LFI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ... --------- Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing whether or not an entity can be coerced into src blend from srcOver, take into account that stroke geometries may modulate with alpha to emulate stroke widths less than 1.0.
While we're at it, update several computations to use max basis XY (from flutter/flutter#153451 ) since that can lead to incorrect stroke width computations in the presence of canvas scaling.
Most of the changes update the APIs that used to take a
const Entity& entityto instead use theconst Matrix& transform, since that is all we used the entity for.See screeenshots in flutter/flutter#154178 (comment)
Fixes flutter/flutter#154178