-
Notifications
You must be signed in to change notification settings - Fork 6k
Add crossOrigin property to <img> tag used for decoding
#54961
Add crossOrigin property to <img> tag used for decoding
#54961
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this testable? LGTM otherwise.
…154655) flutter/engine@652a43b...4844cb4 2024-09-05 1961493+harryterkelsen@users.noreply.github.com Add `crossOrigin` property to <img> tag used for decoding (flutter/engine#54961) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Can we roll this change back? It broke a customer using the HTML renderer in google3 - see flutter/flutter#154809 and b/365475814 |
|
Time to revert pull request flutter/engine/54961 has elapsed. |
…utter#54961)" This reverts commit 4844cb4.
|
Created a manual revert here: #55042 |
…4961)" (#55042) This reverts commit 4844cb4. Reason for revert: We broke users (including a Google internal customer) that depend on credentialed image requests. See flutter/flutter#154809 Fixes flutter/flutter#154809
…utter#54961)" (flutter#55042) This reverts commit 4844cb4. Reason for revert: We broke users (including a Google internal customer) that depend on credentialed image requests. See flutter/flutter#154809 Fixes flutter/flutter#154809
…oding)++ (#57228) Relands #54961 with a few more changes and tests. Fixes flutter/flutter#160127
…oding)++ (flutter/engine#57228) Relands flutter/engine#54961 with a few more changes and tests. Fixes flutter#160127
Adds the
crossOriginproperty to the<img>tag used for decoding. This allows us to use cross-origin images in CanvasKit as if it were loaded from the same origin, as long as the CORS headers are properly set on the server hosting the image.In the case where the image doesn't have proper CORS headers, this change causes an error to occur while attempting to decode, rather than later on in Skia when the image is converted into a texture. Hitting the cross-origin error later causes Skia to behave in undefined ways.
Progress towards flutter/flutter#149843
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.