-
Notifications
You must be signed in to change notification settings - Fork 6k
Reverts "[engine] always force platform channel responses to schedule a task. (#54975)" #55000
Reverts "[engine] always force platform channel responses to schedule a task. (#54975)" #55000
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
…o schedule a task. (flutter#54975)" (flutter/engine#55000)
…o schedule a task. (flutter#54975)" (flutter/engine#55000)
…o schedule a task. (flutter#54975)" (flutter/engine#55000)
flutter/engine@c50eb8a...419fb8c 2024-09-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] always force platform channel responses to schedule a task. (#54975)" (flutter/engine#55000) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions) (flutter/engine#54999) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to 5dqcFlKzRjJb6V95W... (flutter/engine#54998) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions) (flutter/engine#54997) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision) (flutter/engine#54995) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions) (flutter/engine#54992) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg... (flutter/engine#54990) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from 809f868ded1c to aec11ae18bb6 (22 revisions) (flutter/engine#54988) 2024-09-06 [30870216+gaaclarke@users.noreply.github.com](mailto:30870216+gaaclarke@users.noreply.github.com) Removes the int storage from Color (flutter/engine#54714) 2024-09-06 [chris@bracken.jp](mailto:chris@bracken.jp) iOS,macOS: Add logging of duplicate codesign binaries (flutter/engine#54987) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Fuchsia Test Scripts from k4lKsecg0pdIp-U7c... to D9INMR2u4wcyiZ750... (flutter/engine#54984) 2024-09-05 [a-siva@users.noreply.github.com](mailto:a-siva@users.noreply.github.com) Manual roll of Dart. (flutter/engine#54983) 2024-09-05 [chris@bracken.jp](mailto:chris@bracken.jp) iOS,macOS: add unsigned_binaries.txt (flutter/engine#54977) 2024-09-05 [jason-simmons@users.noreply.github.com](mailto:jason-simmons@users.noreply.github.com) Manual Skia roll to 809f868ded1c (flutter/engine#54972) 2024-09-05 [1961493+harryterkelsen@users.noreply.github.com](mailto:1961493+harryterkelsen@users.noreply.github.com) [canvaskit] Fix incorrect calculation of ImageFilter paint bounds (flutter/engine#54980) 2024-09-05 [jonahwilliams@google.com](mailto:jonahwilliams@google.com) [engine] always force platform channel responses to schedule a task. (flutter/engine#54975) 2024-09-05 [tugorez@users.noreply.github.com](mailto:tugorez@users.noreply.github.com) Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from xNv47d1TZmK9 to PBeI0gGvgFdX --------- Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Reverts: #54975
Initiated by: jtmcdole
Reason for reverting: I believe this change caused flutter/flutter to break in an engine roll. It was one of two changes - the other being a webui change.
Tests broken:
module_test_ios: testDualCold
router test: