This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix 'dart --enable-asserts' typo in license check script #55082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
matanlurey
approved these changes
Sep 10, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Wow this is embarrassing. Thanks for the catch!
Contributor
|
test-exempt: This is already a test 🤷🏼 |
Member
Author
The script is fighting us: Lines 7 to 9 in 045377e Could have happened to anyone! |
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2024
…154960) flutter/engine@8a038a6...60c15bc 2024-09-10 58529443+srujzs@users.noreply.github.com Update package:web to use new path and latest revision (flutter/engine#55085) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 82d2e4033333 to 1760de26fb83 (8 revisions) (flutter/engine#55084) 2024-09-10 matanlurey@users.noreply.github.com Move more of the tests in the engine to `package:test` (flutter/engine#55083) 2024-09-10 matanlurey@users.noreply.github.com Redirect `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53717) 2024-09-10 jonahwilliams@google.com [Impeller] reland experimental canvas. (flutter/engine#55047) 2024-09-10 magder@google.com Fix 'dart --enable-asserts' typo in license check script (flutter/engine#55082) 2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from af7460619b2b to 741512e72e92 (1 revision) (flutter/engine#55080) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 4815ec808aa5 to 82d2e4033333 (8 revisions) (flutter/engine#55079) 2024-09-10 rmacnak@google.com Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. (flutter/engine#55051) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 5dc067350ab5 to 4815ec808aa5 (2 revisions) (flutter/engine#55074) 2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d59138eb6ec2 to af7460619b2b (1 revision) (flutter/engine#55073) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from c62380453c72 to 5dc067350ab5 (1 revision) (flutter/engine#55072) 2024-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kIWQ460iagZLxVRPc... to 8XJTJm4D4Go1dBaTi... (flutter/engine#55071) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 9bea95918e69 to c62380453c72 (1 revision) (flutter/engine#55070) 2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from a60078a23978 to d59138eb6ec2 (2 revisions) (flutter/engine#55068) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kIWQ460iagZL to 8XJTJm4D4Go1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
`dart -enable-asserts` should be `--enable-asserts` with two `-`s. License script is complaining: ``` Could not find an option with short name "-e". ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737159074465654417/+/u/test:_licenses_check/stdout Typo from: https://github.com/flutter/engine/pull/54845/files#diff-0845c01add635bd6976b8aefd761c14899002c53f9d0ff596cc7f4667cd49f71R84 Fixes flutter/flutter#154942 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart -enable-assertsshould be--enable-assertswith two-s.License script is complaining:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737159074465654417/+/u/test:_licenses_check/stdout
Typo from:
https://github.com/flutter/engine/pull/54845/files#diff-0845c01add635bd6976b8aefd761c14899002c53f9d0ff596cc7f4667cd49f71R84
Fixes flutter/flutter#154942
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.