Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 30, 2024

Leave an opt out in the engine for iOS as well. This will give developers an escape hatch in case there are problems we miss...

@jonahwilliams jonahwilliams marked this pull request as ready for review October 30, 2024 18:00
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 30, 2024
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@auto-submit auto-submit bot merged commit 549acdf into flutter:main Oct 30, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 30, 2024
…157882)

flutter/engine@2bd854e...9295eeb

2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) (flutter/engine#56243)
2024-10-30 jonahwilliams@google.com [engine] add back opt out for merged thread mode. (flutter/engine#56242)
2024-10-30 jason-simmons@users.noreply.github.com [Impeller] Remove the use of a subpixel minimum stroke size for MSAA (flutter/engine#56223)
2024-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... (flutter/engine#56241)
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) (flutter/engine#56240)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from zuDYsDZHnJMZ to dDWvmfG4AxSE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Leave an opt out in the engine for iOS as well. This will give developers an escape hatch in case there are problems we miss...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants