Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

.ci.yaml Outdated
properties:
config_name: local_engine
# local_engine schedules a bunch of other builds, so it's likely to timeout waiting for those builds to run.
timeout: 90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go even longer, 180?

The shards it is scheduling have their own timeouts too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2024
@auto-submit auto-submit bot merged commit c056b18 into main Oct 31, 2024
35 checks passed
@auto-submit auto-submit bot deleted the matanlurey-patch-1 branch October 31, 2024 17:00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 31, 2024
…157960)

flutter/engine@f2154ef...bb77cf8

2024-10-31 chris@bracken.jp iOS: migrate Metal testing types to ARC (flutter/engine#56156)
2024-10-31 chris@bracken.jp iOS,macOS: migrate shell/gpu to ARC (flutter/engine#56157)
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) (flutter/engine#56272)
2024-10-31 jonahwilliams@google.com [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56221)
2024-10-31 matanlurey@users.noreply.github.com Add `timeout` to `local_engine`. (flutter/engine#56271)
2024-10-31 matanlurey@users.noreply.github.com Refactor `ArgParser.usage` tests for `BuildPlan` to reduce duplication. (flutter/engine#56254)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants