Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android_jit_release_x86. #56548

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

matanlurey
Copy link
Contributor

Closes flutter/flutter#151610.

While it appears unused in google3, cl/695899069 removes trace elements in the build configuration as well.

/cc @a-siva

@matanlurey matanlurey requested a review from jtmcdole November 13, 2024 00:08
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2024
@auto-submit auto-submit bot merged commit 96ada4a into flutter:main Nov 14, 2024
33 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
@zanderso
Copy link
Member

Reason for revert: The tool is still trying to download these artifacts.

@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Nov 15, 2024
Copy link
Contributor

auto-submit bot commented Nov 15, 2024

Time to revert pull request flutter/engine/56548 has elapsed.
You need to open the revert manually and process as a regular pull request.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Nov 15, 2024
zanderso added a commit that referenced this pull request Nov 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
matanlurey pushed a commit that referenced this pull request Nov 16, 2024
Reverts #56548

Failing roll to the framework, the tool is still looking for these
artifacts.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove JIT release x86 mode
3 participants