Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] remove extra validation checks in GLES backend. #56944

Merged
auto-submit merged 1 commit into from
Dec 4, 2024
Merged

[Impeller] remove extra validation checks in GLES backend. #56944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions impeller/renderer/backend/gles/render_pass_gles.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

#include <cstdint>

#include "GLES3/gl3.h"
#include "flutter/fml/trace_event.h"
#include "fml/closure.h"
#include "fml/logging.h"
#include "impeller/base/validation.h"
#include "impeller/core/formats.h"
#include "impeller/renderer/backend/gles/buffer_bindings_gles.h"
#include "impeller/renderer/backend/gles/context_gles.h"
#include "impeller/renderer/backend/gles/device_buffer_gles.h"
#include "impeller/renderer/backend/gles/formats_gles.h"
Expand Down Expand Up @@ -218,7 +218,7 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
}
} else {
// Create and bind an offscreen FBO.
auto cached_fbo = color_gles.GetCachedFBO();
GLuint cached_fbo = color_gles.GetCachedFBO();
if (cached_fbo != GL_NONE) {
fbo = cached_fbo;
gl.BindFramebuffer(GL_FRAMEBUFFER, fbo);
Expand Down Expand Up @@ -289,7 +289,7 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
// Both the viewport and scissor are specified in framebuffer coordinates.
// Impeller's framebuffer coordinate system is top left origin, but OpenGL's
// is bottom left origin, so we convert the coordinates here.
auto target_size = pass_data.color_attachment->GetSize();
ISize target_size = pass_data.color_attachment->GetSize();

//--------------------------------------------------------------------------
/// Setup the viewport.
Expand All @@ -310,16 +310,6 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
}

for (const auto& command : commands) {
if (command.instance_count != 1u) {
VALIDATION_LOG << "GLES backend does not support instanced rendering.";
return false;
}

if (!command.pipeline) {
VALIDATION_LOG << "Command has no pipeline specified.";
return false;
}

#ifdef IMPELLER_DEBUG
fml::ScopedCleanupClosure pop_cmd_debug_marker(
[&gl]() { gl.PopDebugGroup(); });
Expand Down Expand Up @@ -426,11 +416,7 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
break;
}

auto vertex_desc_gles = pipeline.GetBufferBindings();

if (command.index_type == IndexType::kUnknown) {
return false;
}
BufferBindingsGLES* vertex_desc_gles = pipeline.GetBufferBindings();

//--------------------------------------------------------------------------
/// Bind vertex buffers.
Expand Down Expand Up @@ -471,9 +457,10 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
// correct; full triangle outlines won't be drawn and disconnected
// geometry may appear connected. However this can still be useful for
// wireframe debug views.
auto mode = pipeline.GetDescriptor().GetPolygonMode() == PolygonMode::kLine
? GL_LINE_STRIP
: ToMode(pipeline.GetDescriptor().GetPrimitiveType());
GLenum mode =
pipeline.GetDescriptor().GetPolygonMode() == PolygonMode::kLine
? GL_LINE_STRIP
: ToMode(pipeline.GetDescriptor().GetPrimitiveType());

//--------------------------------------------------------------------------
/// Finally! Invoke the draw call.
Expand Down
Loading