New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP][Impeller] fix line/polygon depth and GLES scissor state. (#56494) #57248

Open

jonahwilliams wants to merge 3 commits into flutter:flutter-3.27-candidate.0 from jonahwilliams:fix_depth_tracking

Member

jonahwilliams commented Dec 17, 2024

No description provided.


          [Impeller] fix line/polygon depth and GLES scissor state. (flutter#56494

ee25bed

)

Two problems:

1. We were incorrectly clearing scissor state in the GLES render pass. I suspect this is the cause of all of the clipping problems in wonderous.

2. We were incrementing the depth value in drawPoints with line/polygon mode: these actually need to use the same depth values.

Fixed in the same PR because the golden actually demonstrates both problems with GLES, and luckily I found 2. when I noticed 1.

![image](https://github.com/user-attachments/assets/a5541a51-bdf6-4a47-9638-610d9562df6f)

![image](https://github.com/user-attachments/assets/9f3ad7e1-8193-405d-98c0-49141c8ab662)

github-actions bot added the e: impeller label

jonahwilliams mentioned this pull request

[CP] Fix incorrect depth in drawPoints rendering. flutter/flutter#160459

Open

jonahwilliams added 2 commits

December 17, 2024 12:14


          fix sk point.

0a593ac


          Update impeller_golden_tests_output.txt

2c35d9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels