Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace skia_encode_png_srcs with more granular gni lists. #57258

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anforowicz
Copy link
Contributor

skia_encode_png_base + skia_encode_libpng_srcs is the same as the legacy skia_encode_png_srcs. The latter will be removed from Skia soon.

This is motivated by https://crbug.com/381900683 and the desire to enable using skia_encode_png_base with either
skia_encode_libpng_srcs or (currently experimental) skia_encode_rust_png_srcs.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

`skia_encode_png_base + skia_encode_libpng_srcs` is the same as the
legacy `skia_encode_png_srcs`.  The latter will be removed from Skia
soon.

This is motivated by https://crbug.com/381900683 and the desire to
enable using `skia_encode_png_base` with either
`skia_encode_libpng_srcs` or (currently experimental)
`skia_encode_rust_png_srcs`.
@anforowicz
Copy link
Contributor Author

Ooops... I am guessing that https://skia-review.googlesource.com/c/skia/+/930419 from Skia hasn't yet been rolled into Flutter. I think this means we just need to wait.

/cc @kjlubick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant