Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't drop MotionEvents with unknown tool type. #5931

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Don't drop MotionEvents with unknown tool type. #5931

merged 1 commit into from
Aug 2, 2018

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Aug 2, 2018

Instead, send them with the new unknown PointerDeviceKind.

We hit this when running adb shell input tap in tests which sends events with
an unknown tool type.

This also fills in a missing conversion for TOOL_TYPE_ERASER.

@amirh
Don't drop MotionEvents with unknown tool type.
32e24c2 
Instead, send them with the new unknown PointerDeviceKind.

We hit this when running `adb shell input tap` in tests which sends events with
an unknown tool type.

This also fills in a missing conversion for TOOL_TYPE_ERASER.
@Hixie
Copy link
Contributor

Hixie commented Aug 2, 2018

Thanks!

I'm going to land a benchmark which relies on this and can thus act as a bit of a test.

@Hixie Hixie mentioned this pull request Aug 2, 2018
Merged
@amirh amirh merged commit 3b66f20 into flutter:master Aug 2, 2018
@amirh amirh deleted the pointerkind branch August 2, 2018 23:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..9fe6a57 (5 commits)
aa63d5f 
flutter/engine@4893b07...9fe6a57

git log 4893b07..9fe6a57 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..ffbafc8 (6 commits)
1ab5a7a 
flutter/engine@4893b07...ffbafc8

git log 4893b07..ffbafc8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 3, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..715b64e (7 commits)
3964864 
flutter/engine@4893b07...715b64e

git log 4893b07..715b64e --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..597a508 (8 commits)
3ad7686 
flutter/engine@4893b07...597a508

git log 4893b07..597a508 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..ecbb2b2 (9 commits)
d800d07 
flutter/engine@4893b07...ecbb2b2

git log 4893b07..ecbb2b2 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 liyuqian@google.com Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..aaf4a9a (10 commits)
13d7749 
flutter/engine@4893b07...aaf4a9a

git log 4893b07..aaf4a9a --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 liyuqian@google.com Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..97aea09 (11 commits)
ef26398 
flutter/engine@4893b07...97aea09

git log 4893b07..97aea09 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 liyuqian@google.com Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
@liyuqian liyuqian mentioned this pull request Aug 4, 2018
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2018
@engine-flutter-autoroll
Roll engine 4893b07..63ede2e (12 commits)
5369889 
flutter/engine@4893b07...63ede2e

git log 4893b07..63ede2e --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-05 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 liyuqian@google.com Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine 4893b07..c6baaaf (13 commits)
03e0111 
flutter/engine@4893b07...c6baaaf

git log 4893b07..c6baaaf --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-05 petrhosek@users.noreply.github.com Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 liyuqian@google.com Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine 4893b07..f4464a8 (14 commits)
caf79e8 
flutter/engine@4893b07...f4464a8

git log 4893b07..f4464a8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-06 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
2018-08-05 petrhosek@users.noreply.github.com Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 liyuqian@google.com Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 amirh@users.noreply.github.com Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 amirh@users.noreply.github.com Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 regis@google.com Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 jamesderlin@users.noreply.github.com Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
liyuqian added a commit to liyuqian/flutter that referenced this pull request Aug 6, 2018
@liyuqian
Roll engine to ecbb2b2
f01f69c 
ecbb2b2 Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a508 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64e Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc8 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a57 Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)

Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.
liyuqian added a commit to flutter/flutter that referenced this pull request Aug 6, 2018
@liyuqian
Roll engine to ecbb2b2 (#20230)
8b0a3be 
ecbb2b2 Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a508 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64e Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc8 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a57 Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)

Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amirh @Hixie @jason-simmons @googlebot