Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Add NSNull check in setSystemChromeSystemUIOverlayStyle #6011

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Add NSNull check in setSystemChromeSystemUIOverlayStyle #6011

merged 1 commit into from
Aug 14, 2018

Conversation

NikoYuwono
Copy link
Contributor

Based on report from #20215, there will be an Exception raised by [NSObject(NSObject) doesNotRecognizeSelector:] when calling SystemChrome.setSystemUIOverlayStyle without specifying any value for statusBarBrightness.

After investigation, I found out this is caused because we don't have any NSNull check when getting statusBarBrightness value from dictionary (null from dart world will be converted to NSNull when nested). This can cause calling [NSNull isEqualToString] which will cause doesNotRecognizeSelector being called.

Since I think this is platform specific, it's better to add the check here rather than in the framework side.

@NikoYuwono NikoYuwono force-pushed the fix-overlay-null-20215 branch from dc22658 to ca2ea7f Compare August 14, 2018 09:07
@chinmaygarde chinmaygarde merged commit 6e780fd into flutter:master Aug 14, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..6e780fd (29 commits)
9fecbee 
flutter/engine@e54bc4e...6e780fd

git log e54bc4e..6e780fd --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..d038970 (36 commits)
586c3ed 
flutter/engine@e54bc4e...d038970

git log e54bc4e..d038970 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..69510ab (37 commits)
5868a2d 
flutter/engine@e54bc4e...69510ab

git log e54bc4e..69510ab --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..ad5af2f (38 commits)
48fd8ee 
flutter/engine@e54bc4e...ad5af2f

git log e54bc4e..ad5af2f --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..81baff9 (39 commits)
cd1c74e 
flutter/engine@e54bc4e...81baff9

git log e54bc4e..81baff9 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..e3687f7 (40 commits)
5c6716a 
flutter/engine@e54bc4e...e3687f7

git log e54bc4e..e3687f7 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..7e39999 (41 commits)
2e7d937 
flutter/engine@e54bc4e...7e39999

git log e54bc4e..7e39999 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..829e475 (42 commits)
dc7c268 
flutter/engine@e54bc4e...829e475

git log e54bc4e..829e475 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995)
2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..c09116a (43 commits)
e9eb3c7 
flutter/engine@e54bc4e...c09116a

git log e54bc4e..c09116a --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027)
2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995)
2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..9c0c620 (44 commits)
829e944 
flutter/engine@e54bc4e...9c0c620

git log e54bc4e..9c0c620 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027)
2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995)
2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikoYuwono @chinmaygarde @googlebot