Clear the line baselines when doing each pass of layout #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
cbracken
approved these changes
Aug 20, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2018
flutter/engine@c23690f...5ff4354 git log c23690f..5ff4354 --no-merges --oneline 5ff4354 Clear the line baselines when doing each pass of layout (flutter/engine#6058) 2ff1626 Support LTR/RTL layout directions for embedded Android views. (flutter/engine#6057) d687f9d Roll src/third_party/skia 4f41dcf7d99a..8bbd3fedf55b (4 commits) (flutter/engine#6056) 5903a08 Roll Dart to 69fce633b72e158f5ac553cf3f0f4fcd0f7c735a (flutter/engine#6055) e26643f Rename clipMode to clipBehavior in compositing.dart (flutter/engine#6053) aba09a2 Roll src/third_party/skia 7c42e01cedb9..4f41dcf7d99a (5 commits) (flutter/engine#6054) c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 21, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2018
flutter/engine@e26643f...4e845be git log e26643f..4e845be --no-merges --oneline 4e845be Roll src/third_party/skia 8bbd3fedf55b..ca0cdef06349 (2 commits) (flutter/engine#6061) 5ff4354 Clear the line baselines when doing each pass of layout (flutter/engine#6058) 2ff1626 Support LTR/RTL layout directions for embedded Android views. (flutter/engine#6057) d687f9d Roll src/third_party/skia 4f41dcf7d99a..8bbd3fedf55b (4 commits) (flutter/engine#6056) 5903a08 Roll Dart to 69fce633b72e158f5ac553cf3f0f4fcd0f7c735a (flutter/engine#6055) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#20824