Add a -[FlutterViewController launchView] property
#6112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `-[FlutterViewController launchView]` property that clients can use to customize the launch view (issue #17140).
| Specifies the launch view to initialize the view with. If not specified, uses a view | ||
| generated from `UILaunchStoryboardName` from the main bundle's `Info.plist` file. | ||
| */ | ||
| @property(strong, nonatomic) UIView* launchView; |
There was a problem hiding this comment.
How about splashScreenView? IMO, the name launchView does not make the views purpose immediately clear.
Also, I would amend the docstring to say something like: "Flutters rendering is asynchronous. Due to this, the first frame rendered by the Flutter application may not immediately show up when the UIView is initially placed in the view hierarchy. This view is used a a replacement till the first frame is rendered."
There was a problem hiding this comment.
I would also add note about how the user should configure the launch/splashScreen view for multiple sizes. Saying that an autoresizing mask is applied should be sufficient.
There was a problem hiding this comment.
All good ideas. I've renamed all of the other launchView references to splashScreenView. (I could have just renamed the external property, but I think in the long run it's better for the naming to be consistent everywhere.)
* Rename `-launchView` (and related functions/variables) to `-splashScreenView`. * Add more documentation.
chinmaygarde
approved these changes
Aug 29, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2018
flutter/engine@dc7b5eb...51d4be7 git log dc7b5eb..51d4be7 --no-merges --oneline 51d4be7 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112) a047fd2 Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2018
flutter/engine@dc7b5eb...e7767ae git log dc7b5eb..e7767ae --no-merges --oneline e7767ae Add license file patching instructions to README (flutter/engine#6125) 51d4be7 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112) a047fd2 Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2018
flutter/engine@dc7b5eb...21ac961 git log dc7b5eb..21ac961 --no-merges --oneline 21ac961 Roll src/third_party/skia 8e318fda76df..381efe73499e (11 commits) (flutter/engine#6126) e7767ae Add license file patching instructions to README (flutter/engine#6125) 51d4be7 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112) a047fd2 Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2018
flutter/engine@dc7b5eb...a114659 git log dc7b5eb..a114659 --no-merges --oneline a114659 Roll src/third_party/skia 381efe73499e..f8592a69428e (1 commits) (flutter/engine#6127) 21ac961 Roll src/third_party/skia 8e318fda76df..381efe73499e (11 commits) (flutter/engine#6126) e7767ae Add license file patching instructions to README (flutter/engine#6125) 51d4be7 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112) a047fd2 Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2018
flutter/engine@dc7b5eb...a114659 git log dc7b5eb..a114659 --no-merges --oneline a114659 Roll src/third_party/skia 381efe73499e..f8592a69428e (1 commits) (flutter/engine#6127) 21ac961 Roll src/third_party/skia 8e318fda76df..381efe73499e (11 commits) (flutter/engine#6126) e7767ae Add license file patching instructions to README (flutter/engine#6125) 51d4be7 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112) a047fd2 Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
) Add a `-[FlutterViewController splashScreenView]` property Add a `-[FlutterViewController splashScreenView]` property that clients can use to customize the launch view (issue flutter#17140).
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
) Add a `-[FlutterViewController splashScreenView]` property Add a `-[FlutterViewController splashScreenView]` property that clients can use to customize the launch view (issue flutter#17140).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
-[FlutterViewController launchView]property that clients canuse to customize the launch view (issue #17140).