Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark deprecated Flutter iOS APIs as unavailable #6124

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Mark deprecated Flutter iOS APIs as unavailable #6124

merged 1 commit into from
Aug 31, 2018

Conversation

jamesderlin
Copy link
Contributor

The following were previously marked as deprecated over a month ago:

  • FlutterStandardBigInteger
  • -[FlutterDartProject initFromDefaultSourceForConfiguration]

Remove their implementations and mark them as unavailable.

@jamesderlin
Mark deprecated Flutter iOS APIs as unavailable
129ba62 
The following were previously marked as deprecated over a month ago:
* FlutterStandardBigInteger
* -[FlutterDartProject initFromDefaultSourceForConfiguration]

Remove their implementations and mark them as unavailable.
mravn-google
mravn-google approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jamesderlin jamesderlin merged commit fbf6726 into flutter:master Aug 31, 2018
@jamesderlin jamesderlin deleted the jamesderlin/unavailable branch August 31, 2018 19:34
@jamesderlin jamesderlin mentioned this pull request Aug 31, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2018
@engine-flutter-autoroll
Roll engine 017dafd..fbf6726 (1 commits)
4f9c4a2 
flutter/engine@017dafd...fbf6726

git log 017dafd..fbf6726 --no-merges --oneline
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2018
@engine-flutter-autoroll
Roll engine 017dafd..f44c000 (2 commits)
4a112cf 
flutter/engine@017dafd...f44c000

git log 017dafd..f44c000 --no-merges --oneline
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2018
@engine-flutter-autoroll
Roll engine 017dafd..da41991 (3 commits)
4e136f9 
flutter/engine@017dafd...da41991

git log 017dafd..da41991 --no-merges --oneline
da41991 Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Sep 1, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2018
@engine-flutter-autoroll
Roll engine 017dafd..f25d89a (5 commits)
a5827ec 
flutter/engine@017dafd...f25d89a

git log 017dafd..f25d89a --no-merges --oneline
f25d89a Fix windows embedder builds. (flutter/engine#6137)
b3c778f Allow embedders to specify software renderer configs. (flutter/engine#6133)
da41991 Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 1, 2018
@engine-flutter-autoroll
Roll engine 017dafd..0f7bfea (6 commits)
4de4026 
flutter/engine@017dafd...0f7bfea

git log 017dafd..0f7bfea --no-merges --oneline
0f7bfea Roll src/third_party/skia 6487e5ca6f10..e8e12e89c46b (1 commits) (flutter/engine#6138)
f25d89a Fix windows embedder builds. (flutter/engine#6137)
b3c778f Allow embedders to specify software renderer configs. (flutter/engine#6133)
da41991 Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2018
@engine-flutter-autoroll
Roll engine 017dafd..db3484f (7 commits)
fba8e71 
flutter/engine@017dafd...db3484f

git log 017dafd..db3484f --no-merges --oneline
db3484f Fix crash in text layout when GetMinikinFontCollectionForStyle returns null. (flutter/engine#6139)
0f7bfea Roll src/third_party/skia 6487e5ca6f10..e8e12e89c46b (1 commits) (flutter/engine#6138)
f25d89a Fix windows embedder builds. (flutter/engine#6137)
b3c778f Allow embedders to specify software renderer configs. (flutter/engine#6133)
da41991 Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2018
@engine-flutter-autoroll
Roll engine 017dafd..a447158 (8 commits)
bc6e74d 
flutter/engine@017dafd...a447158

git log 017dafd..a447158 --no-merges --oneline
a447158 Roll src/third_party/skia e8e12e89c46b..8534723c7be1 (1 commits) (flutter/engine#6140)
db3484f Fix crash in text layout when GetMinikinFontCollectionForStyle returns null. (flutter/engine#6139)
0f7bfea Roll src/third_party/skia 6487e5ca6f10..e8e12e89c46b (1 commits) (flutter/engine#6138)
f25d89a Fix windows embedder builds. (flutter/engine#6137)
b3c778f Allow embedders to specify software renderer configs. (flutter/engine#6133)
da41991 Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2018
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 2, 2018
@engine-flutter-autoroll
Roll engine 017dafd..a447158 (8 commits) (#21337)
3b21e34 
flutter/engine@017dafd...a447158

git log 017dafd..a447158 --no-merges --oneline
a447158 Roll src/third_party/skia e8e12e89c46b..8534723c7be1 (1 commits) (flutter/engine#6140)
db3484f Fix crash in text layout when GetMinikinFontCollectionForStyle returns null. (flutter/engine#6139)
0f7bfea Roll src/third_party/skia 6487e5ca6f10..e8e12e89c46b (1 commits) (flutter/engine#6138)
f25d89a Fix windows embedder builds. (flutter/engine#6137)
b3c778f Allow embedders to specify software renderer configs. (flutter/engine#6133)
da41991 Roll src/third_party/skia 7bfe8438a94b..6487e5ca6f10 (6 commits) (flutter/engine#6136)
f44c000 Roll src/third_party/skia 62db8d577931..7bfe8438a94b (20 commits) (flutter/engine#6134)
fbf6726 Mark deprecated Flutter iOS APIs as unavailable (flutter/engine#6124)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@jamesderlin @amirh
Mark deprecated Flutter iOS APIs as unavailable (flutter#6124)
0c736ce 
The following were previously marked as deprecated over a month ago:
* `FlutterStandardBigInteger`
* `-[FlutterDartProject initFromDefaultSourceForConfiguration]`

Remove their implementations and mark them as unavailable.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@jamesderlin
Mark deprecated Flutter iOS APIs as unavailable (flutter#6124)
984383a 
The following were previously marked as deprecated over a month ago:
* `FlutterStandardBigInteger`
* `-[FlutterDartProject initFromDefaultSourceForConfiguration]`

Remove their implementations and mark them as unavailable.
fzyzcjy added a commit to fzyzcjy/engine that referenced this pull request Oct 10, 2022
@fzyzcjy
add PointerDataPacketDispatchMerger, not tested flutter#6124
ce412a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mravn-google mravn-google mravn-google approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesderlin @mravn-google @googlebot