Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform persistent cache stores on the IO thread outside the frame workload. #6350

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Perform persistent cache stores on the IO thread outside the frame workload. #6350

merged 2 commits into from
Sep 26, 2018

Conversation

chinmaygarde
Copy link
Member

The atomic write to the filesystem to store cache contents can take as much as 8ms on low end devices. These stores are now performed on the IO thread and outside the frame workload.

@chinmaygarde
Copy link
Member Author

Along with #6278 fixes flutter/flutter#14028.

liyuqian
liyuqian reviewed Sep 26, 2018
View reviewed changes
shell/common/persistent_cache.cc
std::shared_ptr<fml::UniqueFD> cache_directory,
std::string key,
std::unique_ptr<fml::Mapping> value) {
auto task = fml::MakeCopyable([cache_directory, //
Copy link
Contributor

@liyuqian liyuqian Sep 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The // seems unnecessary. Or is there comment intended after //?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary but the way clang-format mushes the arguments together makes it way less readable (I realize this is a subjective opinion). For unfamiliar APIs

engine/fml/platform/win/file_win.cc

Line 230 in f2a3df9

if (!::DuplicateHandle(
, I'd add the variable name of the value that is supposed to go there so its easier to tell what the 0 or null is supposed to be.

@chinmaygarde chinmaygarde merged commit cc44ca5 into flutter:master Sep 26, 2018
@chinmaygarde chinmaygarde deleted the persistent_cache branch September 26, 2018 23:33
liyuqian
liyuqian reviewed Sep 26, 2018
View reviewed changes
shell/common/persistent_cache.cc
@@ -80,23 +86,81 @@ sk_sp<SkData> PersistentCache::load(const SkData& key) {
return SkData::MakeWithCopy(mapping->GetMapping(), mapping->GetSize());
}

static void PersistentCacheStore(fml::RefPtr<fml::TaskRunner> worker,
std::shared_ptr<fml::UniqueFD> cache_directory,
std::string key,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why std::string key instead of const std::string& key? std::move may save us the copy, but we can type less std::move if we use const std::string&?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventing unnecessary copies as a matter of habit. I don't mind typing the few extra characters (I guess thats subjective). Though I am pretty sure SSOs are already in effect for these particular key strings. But don't want to have to guess.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..26fdd1e (16 commits)
fae5f75 
flutter/engine@38a646e...26fdd1e

git log 38a646e..26fdd1e --no-merges --oneline
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..309ac4e (17 commits)
903f7f7 
flutter/engine@38a646e...309ac4e

git log 38a646e..309ac4e --no-merges --oneline
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..5b79938 (18 commits)
b4e9ff1 
flutter/engine@38a646e...5b79938

git log 38a646e..5b79938 --no-merges --oneline
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..2dd9b99 (19 commits)
dd2feef 
flutter/engine@38a646e...2dd9b99

git log 38a646e..2dd9b99 --no-merges --oneline
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..075b3fc (20 commits)
116ca6f 
flutter/engine@38a646e...075b3fc

git log 38a646e..075b3fc --no-merges --oneline
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
This was referenced Sep 27, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..c589b31 (21 commits)
4b2b57c 
flutter/engine@38a646e...c589b31

git log 38a646e..c589b31 --no-merges --oneline
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..b8c2a17 (22 commits)
2fd2006 
flutter/engine@38a646e...b8c2a17

git log 38a646e..b8c2a17 --no-merges --oneline
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356)
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 38a646e..3052dbd (24 commits)
cb5f26c 
flutter/engine@38a646e...3052dbd

git log 38a646e..3052dbd --no-merges --oneline
3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341)
0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359)
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356)
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 9d4b80a..5ae4708 (13 commits)
d9ad173 
flutter/engine@9d4b80a...5ae4708

git log 9d4b80a..5ae4708 --no-merges --oneline
5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360)
763627f Do not export libdart symbols (flutter/engine#6337)
3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341)
0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359)
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356)
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
This was referenced Sep 27, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 9d4b80a..3a01f39 (14 commits)
6c50396 
flutter/engine@9d4b80a...3a01f39

git log 9d4b80a..3a01f39 --no-merges --oneline
3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361)
5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360)
763627f Do not export libdart symbols (flutter/engine#6337)
3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341)
0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359)
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356)
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 9d4b80a..edf6249 (15 commits)
074f058 
flutter/engine@9d4b80a...edf6249

git log 9d4b80a..edf6249 --no-merges --oneline
edf6249 Add pushOffset to SceneBuilder (flutter/engine#6349)
3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361)
5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360)
763627f Do not export libdart symbols (flutter/engine#6337)
3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341)
0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359)
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356)
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2018
@engine-flutter-autoroll
Roll engine 9d4b80a..d80c1de (16 commits)
9b340f3 
flutter/engine@9d4b80a...d80c1de

git log 9d4b80a..d80c1de --no-merges --oneline
d80c1de Roll src/third_party/skia ab3144c3abb9..656cefe65d62 (11 commits) (flutter/engine#6362)
edf6249 Add pushOffset to SceneBuilder (flutter/engine#6349)
3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361)
5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360)
763627f Do not export libdart symbols (flutter/engine#6337)
3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341)
0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359)
b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356)
c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347)
075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355)
2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354)
5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353)
309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339)
26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351)
cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350)
f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2018
Closed
GaryQian pushed a commit to GaryQian/engine that referenced this pull request Oct 2, 2018
@chinmaygarde @GaryQian
Perform persistent cache stores on the IO thread outside the frame wo…
ae47bed 
…rkload. (flutter#6350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyuqian liyuqian liyuqian left review comments

@jason-simmons jason-simmons jason-simmons approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chinmaygarde @jason-simmons @liyuqian @googlebot