This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Return EngineLayer for all SceneBuilder pushXXX #6814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yjbanov : will this allow you to do the retained rendering in your project? |
|
LGTM if LGT @chinmaygarde |
|
Ping @chinmaygarde |
chinmaygarde
approved these changes
Nov 14, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2018
flutter/engine@14ee957...289de46 git log 14ee957..289de46 --no-merges --oneline 289de46 Return EngineLayer for all SceneBuilder pushXXX (flutter/engine#6814) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are trivial except pushTransform. In pushTransform, matrix4 is a Dart object and it has to be released before we can return a new Dart object (EngineLayer).