Set up secondary isolates with all kernel buffers rather than just one buffer. #6832
Conversation
|
cc @zanderso |
runtime/dart_isolate.cc
Outdated
| @@ -348,8 +348,15 @@ bool DartIsolate::PrepareForRunningFromKernel( | |||
| return false; | |||
| } | |||
|
|
|||
| child_isolate_preparer_ = [mapping](DartIsolate* isolate) { | |||
| return isolate->PrepareForRunningFromKernel(mapping); | |||
| child_isolate_preparer_ = [this](DartIsolate* isolate) { | |||
There was a problem hiding this comment.
Not sure this is thread safe. Instead of referring to this (which could have begun collection on a different thread immediately after spawning a new isolate). Can you can copy the vector and move it into the lambda? The copy is cheap since you are just copying a vector of pointers rather than the mappings themselves.
There was a problem hiding this comment.
So just [kernel_buffers = kernel_buffers_](DartIsolate *isolate) and only when last_piece is true.
There was a problem hiding this comment.
last_piece is already only true by this point. So just copy the kernel buffers vector and you should be good to go :)
|
PTAL - had to add a check to make sure that child_isolate_preparer_ is initialized only once. |
runtime/dart_isolate.cc
Outdated
| child_isolate_preparer_ = [mapping](DartIsolate* isolate) { | ||
| return isolate->PrepareForRunningFromKernel(mapping); | ||
| }; | ||
| if (child_isolate_preparer_ == nullptr) { |
There was a problem hiding this comment.
Could you add a comment here explaining how we might get here more than once, and why we don't want to reinitialize child_isolate_preparer_ in that case?
flutter/engine@99d848a...14ee957 git log 99d848a..14ee957 --no-merges --oneline 14ee957 Set up secondary isolates with all kernel buffers rather than just one buffer. (flutter/engine#6832) 76522eb Roll src/third_party/skia 7f2b6fa66575..f152130ef910 (5 commits) (flutter/engine#6856) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This fixes issue with having secondary isolates not being able to use
package:flutterclasses.