Clear layer cache in RasterCache::Clear #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hixie : any idea on how to unit test this? Can we emulate the "recent app" Android button in golden tests? |
chinmaygarde
approved these changes
Nov 20, 2018
|
Probably a devicelab golden test of some sort. |
|
(Maybe land the fix first, then figure out how to test it once it's landed. Building the infrastructure for doing golden tests in the devicelab would be a useful thing to do during the code freeze.) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2018
…#24596) flutter/engine@8d38417...5c81474 git log 8d38417..5c81474 --no-merges --oneline 5c81474 Clear layer cache in RasterCache::Clear (flutter/engine#6915) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
ele828
added a commit
to ele828/engine
that referenced
this pull request
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes flutter/flutter#24216