load default splash screen when not init with engine #6925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tvolkert
approved these changes
Nov 21, 2018
|
test? |
|
I'm not really sure how we could best test this. We don't have any facilities for running Objective C tests in the engine right now. I started some in https://github.com/flutter/ios_add2app - been talking with @cbracken about how we might be able to get those into the engine repo. |
|
If we could run XCTests, for example, we could assert that a FlutterViewController has a non-nil splash screen for a flutter tool created project. |
|
This change looks fine to me, but I thought that #6883 was intentionally a breaking change; you wanted people to opt-in to using the default splash screen. |
|
@jamesderlin it was only intended to be breaking for add2app cases, not for "regular" flutter apps. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 25, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 25, 2018
flutter/engine@1e37b99...99e73d8 git log 1e37b99..99e73d8 --no-merges --oneline 99e73d8 Roll buildroot to 29a5d76757ec12655c0562b317830f669bd44ea7. (flutter/engine#6929) df2e939 load default splash screen when not init with engine (flutter/engine#6925) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression for regular flutter apps caused by #6883.
Fixes flutter/flutter#24563