This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Wire up support for external OpenGL textures for the embedder. #7087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
requested review from
cbracken,
GaryQian,
jason-simmons and
liyuqian
jason-simmons
approved these changes
Dec 5, 2018
chinmaygarde
force-pushed
the
desktop_textures
branch
from
5328129 to
a812604
Compare
chinmaygarde
force-pushed
the
desktop_textures
branch
from
b8cc377 to
f3cea53
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jan 11, 2019
(cloned from flutter#26399) flutter/engine@e5ec3cf...b7f6bf0 git log e5ec3cf..b7f6bf0 --no-merges --oneline b7f6bf0 Pass deadline to embedder idle notification callback (flutter/engine#7444) 5272805 Fix settings.advisory_script_uri in iOS createShell (flutter/engine#7235) 788dea5 Eliminate std::string using directive (flutter/engine#7433) cd98f6b Clear the font collection&flutter#39;s cache when a font is dynamically loaded (flutter/engine#7436) dea6a08 Remove legacy and deprecated defaultClipBehavior (flutter/engine#7439) 5749b75 Temporary revert of Dart SDK rolls made since 2019/01/08 (flutter/engine#7437) 29c70f5 Roll src/third_party/skia 292ece8024ea..d2fa7e33798c (8 commits) (flutter/engine#7434) 37d886e Simplify rollback of dynamic patches (flutter/engine#7432) 6071286 Download dynamic patch to separate file, then rename it to install. (flutter/engine#7428) 4c9136b Roll src/third_party/dart cb966bdce7a0a9d0c34149b50ae5704676cf34c8..651d19cdaa25d020b8f7c193c907644284029130 (4 commits) 651d19cdaa Ignore --fast-startup flag, assume true aeb7fccd5b Fix plugin start up to work with OverlayResourceProvider 0b0704c7c4 [vm] Use std::abs instead of regular abs(). 36b5fe0c7a Track how many analysis server requests had latency info 239f16e Roll src/third_party/dart 927b0cb9edda5500fed0acbd60c04487d3e526e6..cb966bdce7a0a9d0c34149b50ae5704676cf34c8 (1 commits) cb966bdce7 Unify parsing of co19 test options and regular test options. 2501eb4 Roll src/third_party/dart f4986cc78ddd884e60e7274c44f31dbcd990b912..927b0cb9edda5500fed0acbd60c04487d3e526e6 (73 commits)927b0cb9ed [vm/aot] Support optimization of modulo against a power-of-two. bf13ac85c4 Ensure LSP server clears diagnostics for removed files/analysis roots 54fffe4cca Add support for LSP workspace/didChangeWorkspaceFolders e7b783ba5d Fix bug with deprecated rootPath &flutter#43; add tests ad300b904d Improve handling of server-specific analysis diagnostics pages 1d096d8499 Enable the analyzer Diagnostics server for LSP 6bb1dcdfa4 Fix wording e749576caa [VM/Compiler/AOT] Do not populate unused arguments descriptor in bare instructions mode a1250467fe Move member conflict detection to own method 39a99b0 Docs improvements per @Hixie&flutter#39;s comments (flutter/engine#7387) 26e02aa Wire up support for external OpenGL textures for the embedder. (flutter/engine#7087) 20d70d2 Eliminate unused import of ZipException (flutter/engine#7429) b972f75 Allow embedders to add per shell idle notification callbacks. (flutter/engine#7427) 844d27c Refactor dynamic patching to use clearer naming and structure. (flutter/engine#7426) 99fa390 Roll src/third_party/skia 3560ea702f1b..292ece8024ea (9 commits) (flutter/engine#7424) 97ff4b2 Dart SDK roll for 2019-01-09 39b2e4b Roll src/third_party/skia 76dc683364c2..3560ea702f1b (10 commits) (flutter/engine#7420) 88e212f Dart SDK roll for 2019-01-09 82d3208 Roll src/third_party/skia 1337f5b85978..76dc683364c2 (18 commits) (flutter/engine#7418) 8657340 Dart SDK roll for 2019-01-09 a369ef6 Dart SDK roll for 2019-01-08 3ae5eb8 Dart SDK roll for 2019-01-08 42f449f remove deprecated updateNode argument (flutter/engine#7413) 5e33f33 Refactor shared code into separate function to simplify further work. (flutter/engine#7410) 937ee8b Cleanup dead code (flutter/engine#7409) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
liyuqian
added a commit
to flutter/flutter
that referenced
this pull request
Jan 11, 2019
(cloned from #26399) flutter/engine@e5ec3cf...b7f6bf0 git log e5ec3cf..b7f6bf0 --no-merges --oneline b7f6bf0 Pass deadline to embedder idle notification callback (flutter/engine#7444) 5272805 Fix settings.advisory_script_uri in iOS createShell (flutter/engine#7235) 788dea5 Eliminate std::string using directive (flutter/engine#7433) cd98f6b Clear the font collection's cache when a font is dynamically loaded (flutter/engine#7436) dea6a08 Remove legacy and deprecated defaultClipBehavior (flutter/engine#7439) 5749b75 Temporary revert of Dart SDK rolls made since 2019/01/08 (flutter/engine#7437) 29c70f5 Roll src/third_party/skia 292ece8024ea..d2fa7e33798c (8 commits) (flutter/engine#7434) 37d886e Simplify rollback of dynamic patches (flutter/engine#7432) 6071286 Download dynamic patch to separate file, then rename it to install. (flutter/engine#7428) 4c9136b Roll src/third_party/dart cb966bdce7a0a9d0c34149b50ae5704676cf34c8..651d19cdaa25d020b8f7c193c907644284029130 (4 commits) 651d19cdaa Ignore --fast-startup flag, assume true aeb7fccd5b Fix plugin start up to work with OverlayResourceProvider 0b0704c7c4 [vm] Use std::abs instead of regular abs(). 36b5fe0c7a Track how many analysis server requests had latency info 239f16e Roll src/third_party/dart 927b0cb9edda5500fed0acbd60c04487d3e526e6..cb966bdce7a0a9d0c34149b50ae5704676cf34c8 (1 commits) cb966bdce7 Unify parsing of co19 test options and regular test options. 2501eb4 Roll src/third_party/dart f4986cc78ddd884e60e7274c44f31dbcd990b912..927b0cb9edda5500fed0acbd60c04487d3e526e6 (73 commits)927b0cb9ed [vm/aot] Support optimization of modulo against a power-of-two. bf13ac85c4 Ensure LSP server clears diagnostics for removed files/analysis roots 54fffe4cca Add support for LSP workspace/didChangeWorkspaceFolders e7b783ba5d Fix bug with deprecated rootPath + add tests ad300b904d Improve handling of server-specific analysis diagnostics pages 1d096d8499 Enable the analyzer Diagnostics server for LSP 6bb1dcdfa4 Fix wording e749576caa [VM/Compiler/AOT] Do not populate unused arguments descriptor in bare instructions mode a1250467fe Move member conflict detection to own method 39a99b0 Docs improvements per @Hixie's comments (flutter/engine#7387) 26e02aa Wire up support for external OpenGL textures for the embedder. (flutter/engine#7087) 20d70d2 Eliminate unused import of ZipException (flutter/engine#7429) b972f75 Allow embedders to add per shell idle notification callbacks. (flutter/engine#7427) 844d27c Refactor dynamic patching to use clearer naming and structure. (flutter/engine#7426) 99fa390 Roll src/third_party/skia 3560ea702f1b..292ece8024ea (9 commits) (flutter/engine#7424) 97ff4b2 Dart SDK roll for 2019-01-09 39b2e4b Roll src/third_party/skia 76dc683364c2..3560ea702f1b (10 commits) (flutter/engine#7420) 88e212f Dart SDK roll for 2019-01-09 82d3208 Roll src/third_party/skia 1337f5b85978..76dc683364c2 (18 commits) (flutter/engine#7418) 8657340 Dart SDK roll for 2019-01-09 a369ef6 Dart SDK roll for 2019-01-08 3ae5eb8 Dart SDK roll for 2019-01-08 42f449f remove deprecated updateNode argument (flutter/engine#7413) 5e33f33 Refactor shared code into separate function to simplify further work. (flutter/engine#7410) 937ee8b Cleanup dead code (flutter/engine#7409) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
(cloned from flutter#26399) flutter/engine@e5ec3cf...b7f6bf0 git log e5ec3cf..b7f6bf0 --no-merges --oneline b7f6bf0 Pass deadline to embedder idle notification callback (flutter/engine#7444) 5272805 Fix settings.advisory_script_uri in iOS createShell (flutter/engine#7235) 788dea5 Eliminate std::string using directive (flutter/engine#7433) cd98f6b Clear the font collection&flutter#39;s cache when a font is dynamically loaded (flutter/engine#7436) dea6a08 Remove legacy and deprecated defaultClipBehavior (flutter/engine#7439) 5749b75 Temporary revert of Dart SDK rolls made since 2019/01/08 (flutter/engine#7437) 29c70f5 Roll src/third_party/skia 292ece8024ea..d2fa7e33798c (8 commits) (flutter/engine#7434) 37d886e Simplify rollback of dynamic patches (flutter/engine#7432) 6071286 Download dynamic patch to separate file, then rename it to install. (flutter/engine#7428) 4c9136b Roll src/third_party/dart cb966bdce7a0a9d0c34149b50ae5704676cf34c8..651d19cdaa25d020b8f7c193c907644284029130 (4 commits) 651d19cdaa Ignore --fast-startup flag, assume true aeb7fccd5b Fix plugin start up to work with OverlayResourceProvider 0b0704c7c4 [vm] Use std::abs instead of regular abs(). 36b5fe0c7a Track how many analysis server requests had latency info 239f16e Roll src/third_party/dart 927b0cb9edda5500fed0acbd60c04487d3e526e6..cb966bdce7a0a9d0c34149b50ae5704676cf34c8 (1 commits) cb966bdce7 Unify parsing of co19 test options and regular test options. 2501eb4 Roll src/third_party/dart f4986cc78ddd884e60e7274c44f31dbcd990b912..927b0cb9edda5500fed0acbd60c04487d3e526e6 (73 commits)927b0cb9ed [vm/aot] Support optimization of modulo against a power-of-two. bf13ac85c4 Ensure LSP server clears diagnostics for removed files/analysis roots 54fffe4cca Add support for LSP workspace/didChangeWorkspaceFolders e7b783ba5d Fix bug with deprecated rootPath &flutter#43; add tests ad300b904d Improve handling of server-specific analysis diagnostics pages 1d096d8499 Enable the analyzer Diagnostics server for LSP 6bb1dcdfa4 Fix wording e749576caa [VM/Compiler/AOT] Do not populate unused arguments descriptor in bare instructions mode a1250467fe Move member conflict detection to own method 39a99b0 Docs improvements per @Hixie&flutter#39;s comments (flutter/engine#7387) 26e02aa Wire up support for external OpenGL textures for the embedder. (flutter/engine#7087) 20d70d2 Eliminate unused import of ZipException (flutter/engine#7429) b972f75 Allow embedders to add per shell idle notification callbacks. (flutter/engine#7427) 844d27c Refactor dynamic patching to use clearer naming and structure. (flutter/engine#7426) 99fa390 Roll src/third_party/skia 3560ea702f1b..292ece8024ea (9 commits) (flutter/engine#7424) 97ff4b2 Dart SDK roll for 2019-01-09 39b2e4b Roll src/third_party/skia 76dc683364c2..3560ea702f1b (10 commits) (flutter/engine#7420) 88e212f Dart SDK roll for 2019-01-09 82d3208 Roll src/third_party/skia 1337f5b85978..76dc683364c2 (18 commits) (flutter/engine#7418) 8657340 Dart SDK roll for 2019-01-09 a369ef6 Dart SDK roll for 2019-01-08 3ae5eb8 Dart SDK roll for 2019-01-08 42f449f remove deprecated updateNode argument (flutter/engine#7413) 5e33f33 Refactor shared code into separate function to simplify further work. (flutter/engine#7410) 937ee8b Cleanup dead code (flutter/engine#7409) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes google/flutter-desktop-embedding#107.
On the embedder side, I wired up the
VideoPlayerplugin ingoogle/flutter-desktop-embeddingas an example. That patch is just a rough sketch and not ready for landing however. @stuartmorgan: Let me know when the plugin rework is done. Happy to cleanup that patch and submit.