Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add signal to pointer kinds #8065

Merged
merged 1 commit into from
Mar 7, 2019
Merged

add signal to pointer kinds #8065

merged 1 commit into from
Mar 7, 2019

Conversation

jonahwilliams
Copy link
Member

Fix the build for flutter:

ecuting: /Volumes/DevicelabAndroid/sdk/platform-tools/adb -s ZY22465W9K shell input tap 100 100
2019-03-06T16:19:46.016310: run:stdout: [+1392 ms] E/flutter (15708): [ERROR:flutter/shell/common/shell.cc(178)] Dart Error: Unhandled exception:
2019-03-06T16:19:46.016516: run:stdout: [        ] E/flutter (15708): RangeError (index): Invalid value: Not in range 0..4, inclusive: 5
run:stdout: [        ] E/flutter (15708): #0      List.[] (dart:core/runtime/lib/array.dart:161:52)
2019-03-06T16:19:46.016660: run:stdout: [        ] E/flutter (15708): #1      _unpackPointerDataPacket (dart:ui/hooks.dart:275:37)
2019-03-06T16:19:46.016943: run:stdout: [        ] E/flutter (15708): #2      _dispatchPointerDataPacket (dart:ui/hooks.dart:144:94)
2019-03-06T16:19:46.017514: run:stdout: [        ] E/flutter (15708): [ERROR:flutter/shell/common/shell.cc(178)] Dart Error: Unhandled exception:
2019-03-06T16:19:46.017718: run:stdout: [        ] E/flutter (15708): RangeError (index): Invalid value: Not in range 0..4, inclusive: 5
2019-03-06T16:19:46.017968: run:stdout: [        ] E/flutter (15708): #0      List.[] (dart:core/runtime/lib/array.dart:161:52)
2019-03-06T16:19:46.018177: run:stdout: [        ] E/flutter (15708): #1      _unpackPointerDataPacket (dart:ui/hooks.dart:275:37)
2019-03-06T16:19:46.018393: run:stdout: [        ] E/flutter (15708): #2      _dispatchPointerDataPacket (dart:ui/hooks.dart:144:94)
2019-03-06T16:19:46.034025: "/Volumes/DevicelabAndroid/sdk/platform-tools/adb" exit code: 0

@jonahwilliams jonahwilliams mentioned this pull request Mar 7, 2019
Merged
@jonahwilliams jonahwilliams merged commit 3fb627f into flutter:master Mar 7, 2019
@jonahwilliams jonahwilliams deleted the fix_pointer branch March 7, 2019 02:45
@stuartmorgan
Copy link
Contributor

stuartmorgan commented Mar 7, 2019 •
edited
Loading

This is actually not the right fix; kSingal was left as a pointer kind by mistake. It was supposed to be removed when I switched to have none as a signal kind. It should be removed in the other location rather than added here. Sorry about that.

(On my phone at the moment so can't fix it myself)

@jonahwilliams
Copy link
Member Author

No problem, will revert

jonahwilliams added a commit that referenced this pull request Mar 7, 2019
@jonahwilliams
Revert "add signal to pointer kinds (#8065)"
f72605c 
This reverts commit 3fb627f.
@jonahwilliams jonahwilliams mentioned this pull request Mar 7, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2019
@engine-flutter-autoroll
3fb627f add signal to pointer kinds (flutter/engine#8065)
b0c1c0e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2019
Closed
@mklim mklim mentioned this pull request Mar 7, 2019
Closed
@GaryQian GaryQian mentioned this pull request Mar 7, 2019
Merged
GaryQian added a commit to flutter/flutter that referenced this pull request Mar 8, 2019
@GaryQian
Initialize the lifecycle state with initial state in window. Roll eng…
8f1a430 
…ine (19 commits) (#28688)

git log --oneline --no-merges f4951df..a48cd16
a48cd16 Update a11y word forward/back enum names (flutter/engine#8073)
b5f59ed Delay the vsync callback till the frame start time specified by embedder. (flutter/engine#8072)
7426305 Mark const extern (flutter/engine#8077)
d3f6d7a only partial rule revert (flutter/engine#8078)
d71bfe5 Only build a full Dart SDK when building for the host system (flutter/engine#8071)
de90dbf Refactor web configuration/ Add dartdevc (flutter/engine#7978)
ff46dd3 Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (flutter/engine#8070)
80c6dd2 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (flutter/engine#8069)
68ed654 Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (flutter/engine#8067)
ca0bac4 Revert "add signal to pointer kinds" (flutter/engine#8066)
3fb627f add signal to pointer kinds (flutter/engine#8065)
5a06afa Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (flutter/engine#8063)
a93d99d A11y callback (flutter/engine#8005)
3661d5e Re-land "Buffer lifecycle in WindowData" (flutter/engine#8032)
471a2c8 Send scroll events from the macOS shell (flutter/engine#8056)
2fe9c9b Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (flutter/engine#8060)
3335764 Skip skp files in license check (flutter/engine#8050)
7f16789 Remove redundant thread checker in FML. (flutter/engine#8053)
840c523 Correct URL for Cirrus CI build status badge (flutter/engine#8054)
57c120a remove extra source files (flutter/engine#8052)
4773375 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (flutter/engine#8051)
70a18b5 Add clang static analysis support to gn wrapper (flutter/engine#8047)
b30f989 Improve elevation bounds for physical shape layers (flutter/engine#8044)
e37bd27 Fix weak pointer use violations in shell and platform view. (flutter/engine#8046)
dd80fc9 Add engine support for scrollwheel events (flutter/engine#7494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonahwilliams @stuartmorgan @jason-simmons @googlebot